525190 - Refactor the way pageInfo.js handles arguments

Status: RESOLVED FIXED

(Firefox :: Page Info Window, enhancement)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Comment 1

[Daniel Brooks [:db48x]]

Comment on attachment 409042 [details] [diff] [review]
patch

r=db48x

Comment 2

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/61d1e7b9f1f5

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 409042 [details] [diff] [review]
patch

Is there an add-on compatibility risk to this patch? Looks like it's idempotent, but want to make sure as I've been asked for 1.9.2 approval.

Also, would be nice to know, uhm, why we're doing it.

Comment 4

[Dão Gottwald [:dao]]

There's no compatibility risk, it's just shifting code within a single function. It's needed to land bug 524092 on branch.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 409042 [details] [diff] [review]
patch

a192=beltzner

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/aacc9573ddbd