Closed Bug 525190 Opened 12 years ago Closed 12 years ago

Refactor the way pageInfo.js handles arguments

Categories

(Firefox :: Page Info Window, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3.7a1
Tracking Status
status1.9.2 --- beta4-fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
No description provided.
Attachment #409042 - Flags: review?(db48x)
Attachment #409042 - Flags: review?(db48x) → review+
http://hg.mozilla.org/mozilla-central/rev/61d1e7b9f1f5
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
Attachment #409042 - Flags: approval1.9.2?
Comment on attachment 409042 [details] [diff] [review]
patch

Is there an add-on compatibility risk to this patch? Looks like it's idempotent, but want to make sure as I've been asked for 1.9.2 approval.

Also, would be nice to know, uhm, why we're doing it.
There's no compatibility risk, it's just shifting code within a single function. It's needed to land bug 524092 on branch.
Blocks: 524092
Blocks: 524092
Attachment #409042 - Flags: approval1.9.2?
Comment on attachment 409042 [details] [diff] [review]
patch

a192=beltzner
Attachment #409042 - Flags: approval1.9.2+
You need to log in before you can comment on or make changes to this bug.