525205 - layout/style/nsStyleAnimation.cpp failed to compile with Sun Studio and gcc 4.0

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Ginn Chen]

"../../../layout/style/nsStyleAnimation.cpp", line 516: Error: Pointer type needed instead of nsAutoPtr<nsCSSValuePair>.
"../../../layout/style/nsStyleAnimation.cpp", line 516: Error: Pointer type needed instead of nsAutoPtr<nsCSSValuePair>.
"../../../layout/style/nsStyleAnimation.cpp", line 522: Error: Pointer type needed instead of nsAutoPtr<nsCSSValuePair>.
"../../../layout/style/nsStyleAnimation.cpp", line 522: Error: Pointer type needed instead of nsAutoPtr<nsCSSValuePair>.
4 Error(s) detected.

Comment 1

[Ginn Chen]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This is ugly.

Would it also fix the error if you defined an operator->* on nsAutoPtr<T>, i.e.:

template<class U>
U&
operator->*(U T::* aMember)
  {
    return get()->*aMember;
  }

as a public member of nsAutoPtr<T>?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(And if that doesn't work, what error do you get?)

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

People are also seeing this on gcc 4.0.1:

/Users/moztest/comm/main/src/mozilla/layout/style/nsStyleAnimation.cpp:516: error: no match for ‘operator->*’ in ‘result ->* member’
/Users/moztest/comm/main/src/mozilla/layout/style/nsStyleAnimation.cpp:522: error: no match for ‘operator->*’ in ‘result ->* member’

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/users/dbaron_mozilla.com/patches/raw-file/a042dc183946/auto-ptr-ptr-to-member
is what I was thinking

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch to nsAutoPtr and nsRefPtr

This fixes the error on gcc 4.0.1, per smontagu.

I didn't add to nsAutoArrayPtr, even though it has an operator->; I think it probably shouldn't have that operator->, but that's more than I want to attack right now.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch to nsAutoPtr and nsRefPtr

This one compiles on Windows, and is better anyway.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Well, except some of the Windows tinderboxes hit an ICE compiling TestWinTSF.cpp with that version.  Maybe I should just #ifndef _MSC_VER.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

And it would also be good to know whether this patch actually fixes the error on Sun Studio.

Comment 10

[Ginn Chen]

Yes, it works with Sun Studio.
Thanks!

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch to nsAutoPtr and nsRefPtr

I'm planning to land this shortly, since it fixes broken builds for a bunch of people, but I'm still hoping for after-the-fact review.

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/ee2798619027

Comment 13

[Benjamin Smedberg]

Comment on attachment 409272 [details] [diff] [review]
patch to nsAutoPtr and nsRefPtr

bah, that's ugly, but that's C++ for you