Closed
Bug 525252
Opened 16 years ago
Closed 16 years ago
editproducts.cgi should only list classifications in which there are products you can administer
Categories
(Bugzilla :: Administration, task)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.4
People
(Reporter: LpSolit, Assigned: LpSolit)
Details
Attachments
(1 file)
|
1.22 KB,
patch
|
gregaryh
:
review+
|
Details | Diff | Splinter Review |
If you have product-specific editcomponents privs only, and if useclassifications is turned on, editproducts.cgi lists all existing classifications, including those containing no product which you can edit. This is confusing, and also make harder to remember which classifications you can really go into. The list should be filtered to only display relevant classifications.
|
Assignee | |
Comment 1•16 years ago
|
||
get_products_by_permission() already filters products which you can see, so all the security checks are already done by this method.
Assignee: administration → LpSolit
Status: NEW → ASSIGNED
Attachment #409122 -
Flags: review?(ghendricks)
|
||
Updated•16 years ago
|
Attachment #409122 -
Flags: review?(ghendricks) → review+
|
|
Assignee | |
Updated•16 years ago
|
Flags: approval3.4+
Flags: approval+
|
|
Assignee | |
Comment 2•16 years ago
|
||
tip:
Checking in editproducts.cgi;
/cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v <-- editproducts.cgi
new revision: 1.150; previous revision: 1.149
done
3.4.2:
Checking in editproducts.cgi;
/cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v <-- editproducts.cgi
new revision: 1.147.2.1; previous revision: 1.147
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•