Closed
Bug 525306
Opened 12 years ago
Closed 12 years ago
MOZ_APP_DISPLAYNAME should be Firefox when official branding is enabled
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
VERIFIED
FIXED
fennec1.0b5
People
(Reporter: Gavin, Assigned: Gavin)
Details
Attachments
(1 file, 1 obsolete file)
4.19 KB,
patch
|
Details | Diff | Splinter Review |
This in turn requires changing a couple of places that use it when they really want to always be Fennec: 1) UA string (hardcoded) 2) application.ini (hardcoded) 3) desktop.in - GenericName isn't needed, X-Osso-Service can use MOZ_APP_NAME which is always "fennec" 4) fennec.service.in to match 4) 5) prefs.js, for the on-disk cache location (via app/Makefile.in's -DAPP_NAME) - note that this changes it from "Fennec" to "fennec", I think that's OK? The other users of MOZ_APP_DISPLAYNAME are: 1) Mac packaging stuff in app/Makefile.in (e.g. app bundle name) 2) desktop.in Name and Comment 3) cab installer shortcut 4) updater.ini strings I contend that they are all OK being branding-dependent.
Assignee | ||
Comment 1•12 years ago
|
||
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #409164 -
Flags: review?(mark.finkle)
Attachment #409164 -
Flags: review?(bugmail)
Comment 2•12 years ago
|
||
(In reply to comment #0) > 3) desktop.in - GenericName isn't needed, X-Osso-Service can use MOZ_APP_NAME > which is always "fennec" > 4) fennec.service.in to match 4) agreed > 5) prefs.js, for the on-disk cache location (via app/Makefile.in's -DAPP_NAME) > - note that this changes it from "Fennec" to "fennec", I think that's OK? should be fine > The other users of MOZ_APP_DISPLAYNAME are: > 1) Mac packaging stuff in app/Makefile.in (e.g. app bundle name) > 2) desktop.in Name and Comment > 3) cab installer shortcut > 4) updater.ini strings > > I contend that they are all OK being branding-dependent. agreed
Comment 3•12 years ago
|
||
Comment on attachment 409164 [details] [diff] [review] patch > #filter substitution > [D-BUS Service] >-Name=Mozilla.@MOZ_APP_DISPLAYNAME@ >+Name=Mozilla.@MOZ_APP_NAME@ Name=mozilla.@MOZ_APP_NAME@
Attachment #409164 -
Flags: review?(mark.finkle) → review+
Updated•12 years ago
|
Attachment #409164 -
Flags: review?(bugmail) → review+
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #409164 -
Attachment is obsolete: true
Assignee | ||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mobile-browser/rev/7fabd9fbc27c
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → B5
Comment 6•12 years ago
|
||
verified FIXED on build: Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b2pre) Gecko/20091102 Namoroka/3.6b2pre Fennec/1.0b5
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•