525371 - TM: Remove TreeInfo

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

When bug 524620 lands, which re-organizes Fragment layouts, TreeInfo is unnecessary and adds a lot of complication. With this gone we can have better lifetime management of fragments and less random indirection.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: patch

Passes trace-tests but not ready to review yet. Applies on top of bug 524620.

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: rebased

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: rebased, again

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: rebased

Comment 5

[Luke Wagner [:luke]]

Comment on attachment 414128 [details] [diff] [review]
rebased

Great patch; shorter, simpler, smaller, and maybe even a hair faster.

Only superficial requests:

1. Could you properly indent/align:
 - the #ifdef'd JS_JIT_SPEW block in RecordTree
 - the branchCount member declaration in LinkableFragment
 - the TreeFragment constructor call in AddNewPeerToPeerList

2. I think the assert:

 JS_ASSERT(fragment->root == tree);

isn't necessary considering the initialization of 'tree'.

Comment 6

[David Anderson [:dvander] - inactive, e-mail if emergency]

pushed with nits as http://hg.mozilla.org/tracemonkey/rev/0082849624a5

Comment 7

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/0082849624a5

Comment 8

[Robert Sayre]

oops, that got backed out

Comment 9

[David Anderson [:dvander] - inactive, e-mail if emergency]

The tree is green again so re-pushing: http://hg.mozilla.org/tracemonkey/rev/0240dfe10411

Comment 10

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/0240dfe10411