525394 - test_autocomplete.js failures | old but not senior == senior citizen

Status: RESOLVED FIXED

(Toolkit :: Form Manager, defect)

Description

[Dietrich Ayala (:dietrich)]

TEST-UNEXPECTED-FAIL | e:\builds\moz2_slave\mozilla-central-win32-unittest-everythingelse\build\xpcshell\tests\test_satchel\unit\test_autocomplete.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | e:/builds/moz2_slave/mozilla-central-win32-unittest-everythingelse/build/xpcshell/tests/test_satchel/unit/test_autocomplete.js | old but not senior == senior citizen - See following stack:
TEST-UNEXPECTED-FAIL | (xpcshell/head.js) | FAILED in test #7 -- 2147500036

Comment 1

[Phil Ringnalda (:philor)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1258302997.1258308188.8545.gz
WINNT 5.2 mozilla-central debug test everythingelse on 2009/11/15 08:36:37
"s: moz2-win32-slave16"

Comment 2

[Timothy Nikkel (:tnikkel)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1259820852.1259829133.2268.gz

Comment 3

[Benjamin Smedberg]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1261506495.1261511870.31274.gz

Comment 4

[Mike Hommey [:glandium]]

I got the same problem on a linux x86-64 1.9.2 build. It's absolutely weird, because the test code reads:
        do_check_eq(results.getValueAt(0), "senior citizen");
        do_check_eq(results.getValueAt(1), "old but not senior");

It fails on the first of these 2 lines. But here are the things I tried and got me amazing results:
- If I invert those two lines, the tests pass.
- If I add a "dump(results);" before the first test, the tests pass.
- Even better, if I add an empty commented line ("//") before the first test, the tests pass.

Comment 5

[Mike Hommey [:glandium]]

Three empty lines before the first test are also enough.

Comment 6

[Mike Hommey [:glandium]]

Running through valgrind makes it reliably pass, while running several times in a row makes it fail 80% of the time for me.

Comment 7

[Jonathan Kew [:jfkthame]]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1267189042.1267190341.8343.gz
WINNT 5.2 mozilla-central opt test xpcshell on 2010/02/26 04:57:22
s: win32-slave10

Comment 8

[Mike Hommey [:glandium]]

This is clearly a race condition, and it gets worse when JIT is enabled on x86-64.

Comment 9

[Legacy TBPL/Treeherder Robot]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270738056.1270739780.32531.gz
Linux mozilla-central debug test xpcshell, Started 07:47, finished 08:17

Comment 10

[Phil Ringnalda (:philor)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1272623905.1272625609.24307.gz
Linux mozilla-central debug test xpcshell on 2010/04/30 03:38:25
s: moz2-linux-slave27

Comment 11

[Matthew N. [:MattN]]

My mistake, I see the race condition and I'll have a patch up in the next few days.

Comment 12

[Matthew N. [:MattN]]

Attachment: Patch v.1 +/- one minute

Patch using expiry date +/- one minute

Comment 13

[Mike Hommey [:glandium]]

http://hg.mozilla.org/mozilla-central/rev/17c47bc94015

Comment 14

[Mark Banner (:standard8)]

Comment on attachment 443262 [details] [diff] [review]
Patch v.1 +/- one minute

Requesting approval for 1.9.2.9 - I've seen this random orange a few times on the Thunderbird 3.1 tinderboxes and would like to clean it up there.

This is a test-only change.

Comment 15

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 443262 [details] [diff] [review]
Patch v.1 +/- one minute

a=beltzner, test fix

Comment 16

[Mark Banner (:standard8)]

Checked into 1.9.2: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/a6624c6bd155