check-locales.py checks for $(LOCALE_SRCDIR)/installer/ directory preventing l10n-merge from succeeding

RESOLVED WORKSFORME

Status

()

Firefox
Build Config
RESOLVED WORKSFORME
8 years ago
7 years ago

People

(Reporter: stas, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

8 years ago
In http://mxr.mozilla.org/mozilla1.9.2/source/browser/locales/Makefile.in#189 we're calling check-locales.py on $(LOCALE_SRCDIR)/installer, which returns the following error if installer/ doesn't exist, independently of the current platform [1]:

Verifying x-testing installer variable usage
Not a directory at /Users/stas/Mozilla/vc/koala-l10n/application/Firefox/3.6/toolkit/mozapps/installer/windows/nsis/check-locales.pl line 110.
make[1]: *** [tests] Error 2

[1] as per http://mxr.mozilla.org/mozilla1.9.2/source/toolkit/mozapps/installer/windows/nsis/check-locales.pl#109

This causes the build (or langpack) to fail on non-Windows platforms, but more importantly doesn't allow l10n-merge to merge the locale files with en-US.

Comment 1

7 years ago
The check-locales tests are gone on trunk, marking this WORKSFORME.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.