525470 - Fennec 1.0b5 deb packages are broken

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Nightly Fennec deb fails to launch. The deb is empty. Multi-locale build is overwriting a good single locale deb with a bad multi-locale deb.

Tinderbox log:
http://tinderbox.mozilla.org/showlog.cgi?log=Mobile/1256889604.1256892737.7178.gz&fulltext=1

Search for "fennec_1.0b5_armel.deb" and you will see a 556KB (good) file uploaded and then a 24KB (bad) file uploaded.

The bad file is the result of repacking the deb from the multi-locale bz2 archive.

The | make deb | code assumes the bz2 package has a specific name and it is trying to use the en-US bz2, which was removed (and not what we want to use):

bunzip2: Can't open input file ../../dist/fennec-1.0b5.en-US.linux-gnueabi-arm.tar.bz2: No such file or directory.

Comment 1

[Armen [:armenzg]]

This probably is because of the step that removes the packages from the single-locale build:
http://mxr.mozilla.org/build/source/buildbotcustom/process/factory.py#4069

*sigh* I can see fixing this by doing the single-locale build completely separated from the multi-locale build (bug 525327). It was a bad choice to have both happening in the same builder.

Comment 2

[Chris Cooper [:coop] (he/him)]

I have a patch for this running in staging right now.

Comment 3

[Chris Cooper [:coop] (he/him)]

Attachment: Pass extraArgs to the 'make deb' command

I also pass the extraArgs to the other commands in this block as well, but they aren't used at present.

This is running in staging right now.

Comment 4

[Chris Cooper [:coop] (he/him)]

(In reply to comment #3)
> This is running in staging right now.

...and the successful step log is here:

http://staging-master.build.mozilla.org:8011/builders/Maemo%20mozilla-1.9.2%20nightly/builds/81/steps/make_mobile_deb_2/logs/stdio

Comment 5

[Chris Cooper [:coop] (he/him)]

Comment on attachment 409406 [details] [diff] [review]
Pass extraArgs to the 'make deb' command

http://hg.mozilla.org/build/buildbotcustom/rev/f2a9d86c5479

Comment 6

[Chris Cooper [:coop] (he/him)]

Looks fixed according to:

http://tinderbox.mozilla.org/showlog.cgi?log=Mobile/1256939530.1256944478.22556.gz

Comment 7

[Armen [:armenzg]]

Verified:
 1) The multi-locale's deb was generated of the multi-locale's tar ball
 2) The size of the deb uploaded makes more sense

[1]
bunzip2 -c ../../dist/fennec-1.0b5.multi.linux-gnueabi-arm.tar.bz2 | tar -xf- -C debian/fennec//usr/local/fennec-1.0b5

[2]
fennec_1.0b5_armel.deb	31-Oct-2009 01:56 	1.2M
fennec-1.0b5.multi.linux-gnueabi-arm.tar.bz2	31-Oct-2009 01:56 	11M
xulrunner-1.9.2b2pre.en-US.linux-gnueabi-arm.tests.tar.bz2	31-Oct-2009 01:54 	9.2M
xulrunner-1.9.2b2pre.en-US.linux-gnueabi-arm.tar.bz2	31-Oct-2009 01:54 	9.8M
xulrunner_1.9.2b2pre-20091031010516_armel.deb	31-Oct-2009 01:54 	11M
fennec-1.0b5.en-US.linux-gnueabi-arm.tar.bz2	31-Oct-2009 01:54 	10M