crash [@ nsNetscapeProfileMigratorBase::CopyCookies(int)]

RESOLVED FIXED in Thunderbird 3.1a1

Status

MailNews Core
Profile Migration
--
critical
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: wsmwk, Assigned: timeless)

Tracking

({crash, fixed-seamonkey2.0.3, topcrash})

Trunk
Thunderbird 3.1a1
crash, fixed-seamonkey2.0.3, topcrash
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird3.0 .1-fixed)

Details

(crash signature)

Attachments

(1 attachment, 1 obsolete attachment)

crash [@ nsNetscapeProfileMigratorBase::CopyCookies(int)]

#2 crash for 2.0
slightly different stacks from crash-stats

bp-a5f42260-4956-46ee-bd4c-0fa862091029
We need more info on how to import mail settings from 1.1.18 to 2.0
0	suite.dll	nsNetscapeProfileMigratorBase::CopyCookies	 suite/profile/migration/src/nsNetscapeProfileMigratorBase.cpp:797
1	suite.dll	nsThunderbirdProfileMigrator::Migrate	suite/profile/migration/src/nsThunderbirdProfileMigrator.cpp:98
2	xpcom_core.dll	NS_InvokeByIndex_P	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:101
3	seamonkey.exe	XPCWrappedNative::CallMethod	js/src/xpconnect/src/xpcwrappednative.cpp:2297
4	seamonkey.exe	XPC_WN_CallMethod	js/src/xpconnect/src/xpcwrappednativejsops.cpp:1590
5	js3250.dll	js_Invoke	js/src/jsinterp.cpp:1386
6	seamonkey.exe	XPC_WN_GetObjectOpsWithCall	js/src/xpconnect/src/xpcwrappednativejsops.cpp:1398 


bp-5b9dff18-c26c-401f-9496-c59222090818
trying import settings from thunderbird
0	libsuite.so	nsNetscapeProfileMigratorBase::CopyCookies	 suite/profile/migration/src/nsNetscapeProfileMigratorBase.cpp:769
1	libsuite.so	nsThunderbirdProfileMigrator::Migrate	suite/profile/migration/src/nsThunderbirdProfileMigrator.cpp:99
2	libxpcom_core.so	NS_GetXPTCallStub_P	
3	seamonkey-bin	XPCWrappedNative::CallMethod	js/src/xpconnect/src/xpcwrappednative.cpp:2710
4	seamonkey-bin	XPC_WN_CallMethod	js/src/xpconnect/src/xpcwrappednativejsops.cpp:1740
5	libmozjs.so	js_Invoke	js/src/jsinterp.cpp:1371
6	libmozjs.so	js_Interpret	js/src/jsops.cpp:2199
7	libmozjs.so	js_Invoke	js/src/jsinterp.cpp:1379
8	libmozjs.so	js_InternalInvoke	js/src/jsinterp.cpp:1434
9	libmozjs.so	JS_CallFunctionValue	js/src/jsapi.cpp:5124
10	seamonkey-bin	nsJSContext::CallEventHandler	dom/base/nsJSEnvironment.cpp:2097
11	seamonkey-bin	nsGlobalWindow::RunTimeout	dom/base/nsGlobalWindow.cpp:7935
12	seamonkey-bin	nsGlobalWindow::TimerCallback	dom/base/nsGlobalWindow.cpp:8269
Flags: blocking-seamonkey2.0.1?
Version: unspecified → Trunk

Comment 1

8 years ago
Hmm, looks like it had trouble finding the source profile...

Comment 2

8 years ago
Forwarding blocking request to next security/stability update. If this crash is happening frequently, we really would like to get a hold on it...

Neil, any chance to find out what really goes wrong there?
Flags: blocking-seamonkey2.0.1? → blocking-seamonkey2.0.2?

Comment 3

8 years ago
http://crash-stats.mozilla.com/topcrasher/byversion/SeaMonkey/2.0 still says this is a very high-profile crasher, see http://crash-stats.mozilla.com/report/list?range_value=2&range_unit=weeks&signature=nsNetscapeProfileMigratorBase%3A%3ACopyCookies%28int%29&version=SeaMonkey%3A2.0 for more crash reports for that signature, 179 in the last week coming from Windows, but 2 also from Linux.
(Assignee)

Comment 4

8 years ago
Created attachment 417024 [details] [diff] [review]
match other caller
Attachment #417024 - Flags: review?(neil)
(Assignee)

Updated

8 years ago
Assignee: nobody → timeless
Status: NEW → ASSIGNED

Comment 5

8 years ago
(In reply to comment #4)
> Created an attachment (id=417024)
> match other caller
Which other caller? nsSeamonkeyProfileMigrator::Migrate has identical code.
(Assignee)

Comment 6

8 years ago
Created attachment 417259 [details] [diff] [review]
match nsSeamonkeyProfileMigrator::GetMigrateData
Attachment #417024 - Attachment is obsolete: true
Attachment #417259 - Flags: review?(neil)
Attachment #417024 - Flags: review?(neil)

Comment 7

8 years ago
Comment on attachment 417259 [details] [diff] [review]
match nsSeamonkeyProfileMigrator::GetMigrateData

I can only assume that somehow we're calling Migrate even though GetMigrateData has failed, or something. I guess this can't hurt.
Attachment #417259 - Flags: review?(neil) → review+
Don't forget that timeless will never look at this bug again, so someone else will need to drive it into the branch.
Keywords: checkin-needed

Updated

8 years ago
Attachment #417259 - Flags: approval-seamonkey2.0.2+
Comment on attachment 417259 [details] [diff] [review]
match nsSeamonkeyProfileMigrator::GetMigrateData

Looking for "r+a-thunderbird3.0.1".
Attachment #417259 - Flags: review?(bugzilla)
Attachment #417259 - Flags: review?(bugzilla) → review?(bienvenu)

Comment 10

8 years ago
Comment on attachment 417259 [details] [diff] [review]
match nsSeamonkeyProfileMigrator::GetMigrateData

can you put the return NS_ERROR_FAILURE; on its own line for each of breakpoint setting? thx!
Attachment #417259 - Flags: review?(bienvenu) → review+
(In reply to comment #9)
> (From update of attachment 417259 [details] [diff] [review])
> Looking for "r+a-thunderbird3.0.1".

This needs fixing up and landing on trunk before you can get approval (as per the standard branch rules).
(Assignee)

Comment 12

8 years ago
http://hg.mozilla.org/comm-central/rev/5530c00d27da
approval-thunderbird3.0=Standard8
(Assignee)

Updated

8 years ago
Component: General → Profile Migration
Product: SeaMonkey → MailNews Core
QA Contact: general → profile-migration
(Assignee)

Comment 14

8 years ago
i don't have the resources to push this into comm-1.9.1, could someone please push it for me (presumably just grab the commit from comment 12 and add the a= from comment 13)
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Attachment #417259 - Flags: approval-thunderbird3.0.1+
Pushed to branch: http://hg.mozilla.org/releases/comm-1.9.1/rev/643046e2565b
status-thunderbird3.0: --- → .1-fixed
(In reply to comment #15)
> Pushed to branch: http://hg.mozilla.org/releases/comm-1.9.1/rev/643046e2565b

This push misses comment 10 nit ... I guess we don't care too much on c-1.9.1...
Flags: blocking-seamonkey2.0.2?
Hardware: x86 → All
Target Milestone: --- → Thunderbird 3.1a1
Keywords: checkin-needed → fixed-seamonkey2.0.2
Ftr, Firefox had this check added in
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/browser/components/migration/src/nsSeamonkeyProfileMigrator.cpp&mark=1.18#1.19

*****

While there, I noticed
{
browser:
94     GetProfilePath(aStartup, mTargetProfile);

+++ b/mail/components/migration/src/nsSeamonkeyProfileMigrator.cpp
     GetProfilePath(aStartup, mTargetProfile);

+++ b/suite/profile/migration/src/nsSeamonkeyProfileMigrator.cpp
     GetProfilePath(aStartup, getter_AddRefs(mTargetProfile));
}
Is it expected that SeaMonkey (only) uses 'getter_AddRefs()'?
(In reply to comment #17)
> 94     GetProfilePath(aStartup, mTargetProfile);
> 
> +++ b/mail/components/migration/src/nsSeamonkeyProfileMigrator.cpp
>      GetProfilePath(aStartup, mTargetProfile);
> 
> +++ b/suite/profile/migration/src/nsSeamonkeyProfileMigrator.cpp
>      GetProfilePath(aStartup, getter_AddRefs(mTargetProfile));
> }
> Is it expected that SeaMonkey (only) uses 'getter_AddRefs()'?
Yeah, we use ordinary XPCOM getters rather than weird nsCOMPtr references.
Depends on: 601347
Depends on: 601715
Crash Signature: [@ nsNetscapeProfileMigratorBase::CopyCookies(int)]
You need to log in before you can comment on or make changes to this bug.