52552 - new bookmarks aren't being added to top-level menu on Mac

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P2)

Description

[Claudius Gayle]

***Overview Description: 

  On the mac new bookmarks are failing to appear in the top level
bookmarks menu when added. They show up everywhere else, just not the
menu.

***Steps to Reproduce: 

1) Load any page.

2) Select Bookmarks|Add Current Page

3) Select the Bookmarks menu again and observe.


***Actual Results: 

	The new bookmark is not added to the menu. It is however added
to the sidebar panel, the optional bookmarks popup on the ptoolbar, and
it appears in the Manage bookmarks window.

***Expected Results: 

It should in appear in all four(4) places, especially the menu!

***Build Date & Platform Info: 

Mac only! Reproduced in 2000091204 and 2000091304. MacOS 8.5.1/9.
Tested and NOT repro'd on Linux and Win98 2000091304 builds.

Comment 1

[Claudius Gayle]

nominating nsbeta3 and adding regression keyword. This is an apparent major loss of
function.
slamm, is there someone on the toolkit side that might be involved with this?

Comment 2

[Adam]

If you exit and restart Mozilla, the bookmarks will show up in the menu.
Temporary workaround.

Comment 3

[clayton]

It's awful, but the history mechanism and workaround mean this isn't a ship 
stopper.

Comment 4

[johng]

nav triage team:
this is the #1 way to use bookmarks.  If the other ways were not working, that 
would be OK, but not this method.  P2

Comment 5

[scottputterman]

I haven't tried this on a mac yet, but try using mail. Go to Messages | Move 
Message and open up the menus and look at your folders.

Now try adding a new folder to one of your mail accounts. Does it show up in the 
Move Message menu? If it doesn't we might have a problem with adding to 
menuitems on Mac or at least to adding to RDF generated menus.  If it does show 
up then this might be bookmark menu specific.

Comment 6

[selmer (gone)]

pdt now agrees p2.

Comment 7

[scottputterman]

well, my previous comments may not have been accurate.  Move Message works fine
but it is a popup, not a top level menu.

On the Mac, I do notice that code we have in mailnews to hide or show menus
doesn't seem to work on top level menus either. But they do work on Linux and
Windows. I'm wondering if they aren't editable.  cc'ing pinkerton.

Comment 8

[Mike Pinkerton (not reading bugmail)]

composer does lots of fancy showing and hiding of top-level menus, and that all 
works.

Comment 9

[scottputterman]

Are you sure?  In my mozilla debug build on the mac, Check Spelling shows up in
the Edit menu in Editor even though there's code that tries to hide it (I know
the code gets called because I put a dump statement in there).  In mailnews, if
you open a standalone message window, almost all of the menuitems/menus in the
View menu are supposed to be hidden but aren't.  Could something have broken
recently?

Comment 10

[Mike Pinkerton (not reading bugmail)]

ok, for this bug, it's saari's. we've started caching toplevel menus and it's not 
being rebuilt on the contentInserted event.

if you have other items that should be hidden and aren't, file bugs. we in 
toolkit don't know what items should be there and which shouldn't ;)

Comment 11

[scottputterman]

ok, I will do that.  I just started noticing this on the Mac when looking at
bookmarks and trying to find something to compare it to in other windows.
Though, I think nbaca pointed this out to me earlier.  I will file a general bug
about hiding menu items on saari. thanks!

Comment 12

[saari (gone)]

Fixed

Comment 13

[shrirang khanzode]

verified fixed with build 2000092212m18.