We want to take this upgrade to fix crash bug 523405. This is a common crash that occurs when people try to delete more than 32k history entries (which is apparently common).
Created attachment 409401 [details] [diff] [review] v1.0 We don't do review for upgrades since it's just a code drop. Here it is (Mozilla and SQLite changes all in one patch).
Comment on attachment 409401 [details] [diff] [review] v1.0 This applies (with fuzz 1) on 1.9.2.
Created attachment 409403 [details] [diff] [review] 1.9.1 v1.0 Did not apply cleanly to 1.9.1 though, but this one will.
This also impacts 1.9.0, but we have SQLite version 3.6.10 there (not 3.6.16). Are we interested in taking this there? It'd be a much bigger patch there.
Landed on 1.9.2: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/b443a49e0185
Comment on attachment 409403 [details] [diff] [review] 1.9.1 v1.0 Approved for 220.127.116.11, a=dveditz for release-drivers
Landed on 1.9.1: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/c4c7d2498e2e
I'm seeing a possible new signature sqlite3VdbeDelete show up in early 3.6beta3 that we didn't see in b1 or b2. could that be a possible regression from this landing? the dates don't seem to line up. see bug 529478 for the b3 bug.
(In reply to comment #10) > I'm seeing a possible new signature sqlite3VdbeDelete show up in early 3.6beta3 > that we didn't see in b1 or b2. Take a look at the patch... I really, really doubt it. Note that we saw that crash on 1.9.1 in the last week as well...
I would mention bug 524144, but it's only landed on trunk and not 1.9.2 or 1.9.1...