Bug 525539 (SQLite3.6.16.1)

Upgrade to SQLite 3.6.16.1

RESOLVED FIXED in mozilla1.9.3a1

Status

()

Toolkit
Storage
P2
normal
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: sdwilsh, Assigned: sdwilsh)

Tracking

Trunk
mozilla1.9.3a1
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.9.2 +

Firefox Tracking Flags

(status1.9.2 beta2-fixed, status1.9.1 .6-fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

8 years ago
We want to take this upgrade to fix crash bug 523405.  This is a common crash that occurs when people try to delete more than 32k history entries (which is apparently common).
Flags: blocking1.9.2?
(Assignee)

Comment 1

8 years ago
Created attachment 409401 [details] [diff] [review]
v1.0

We don't do review for upgrades since it's just a code drop.  Here it is (Mozilla and SQLite changes all in one patch).
(Assignee)

Updated

8 years ago
blocking1.9.1: --- → ?
(Assignee)

Comment 2

8 years ago
http://hg.mozilla.org/mozilla-central/rev/b74a57e6d96e
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

8 years ago
Comment on attachment 409401 [details] [diff] [review]
v1.0

This applies (with fuzz 1) on 1.9.2.
Attachment #409401 - Flags: approval1.9.2?
(Assignee)

Comment 4

8 years ago
Created attachment 409403 [details] [diff] [review]
1.9.1 v1.0

Did not apply cleanly to 1.9.1 though, but this one will.
Attachment #409403 - Flags: approval1.9.1.5?
(Assignee)

Comment 5

8 years ago
This also impacts 1.9.0, but we have SQLite version 3.6.10 there (not 3.6.16).  Are we interested in taking this there?  It'd be a much bigger patch there.
Flags: blocking1.9.2? → blocking1.9.2+
Priority: -- → P2
(Assignee)

Updated

8 years ago
Attachment #409401 - Flags: approval1.9.2?
(Assignee)

Comment 6

8 years ago
Comment on attachment 409401 [details] [diff] [review]
v1.0

Blocking, so I no longer need approval.
(Assignee)

Comment 7

8 years ago
Landed on 1.9.2:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/b443a49e0185
status1.9.2: --- → final-fixed
Comment on attachment 409403 [details] [diff] [review]
1.9.1 v1.0

Approved for 1.9.1.6, a=dveditz for release-drivers
Attachment #409403 - Flags: approval1.9.1.6? → approval1.9.1.6+
blocking1.9.1: ? → ---
status1.9.1: --- → wanted
(Assignee)

Comment 9

8 years ago
Landed on 1.9.1:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/c4c7d2498e2e
status1.9.1: wanted → .6-fixed

Comment 10

8 years ago
I'm seeing a possible new signature sqlite3VdbeDelete show up in early 3.6beta3 that we didn't see in b1 or b2.

could that be a possible regression from this landing?  the dates don't seem to line up. 

see bug 529478 for the b3 bug.
(In reply to comment #10)
> I'm seeing a possible new signature sqlite3VdbeDelete show up in early 3.6beta3
> that we didn't see in b1 or b2.

Take a look at the patch... I really, really doubt it.

Note that we saw that crash on 1.9.1 in the last week as well...
I would mention bug 524144, but it's only landed on trunk and not 1.9.2 or 1.9.1...
(Assignee)

Updated

7 years ago
Alias: SQLite3.6.16.1
Target Milestone: --- → mozilla1.9.3a1
Blocks: 538747
You need to log in before you can comment on or make changes to this bug.