525561 - Ctrl+K doesn't select existing search terms in quicksearch box

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Thomas D. (:thomas8)]

STR

1 e.g. in main window, write some search words into quicksearch box (do not press enter)
2 press ctrl+k

actual
- focus is set to search box, but search words aren't selected

expected
- focus is set to search box, and search words are selected
(this is the current behaviour in TB2, and in FF, too)

This will make it easier to do a new search/filter for something else.

Comment 1

[Wayne Mery (:wsmwk)]

and also allow clear of search without mouse or extra keystrokes.
(i rather dislike workflow distruptors like this)
I suspect bug  474711 (so blocking to bug 474701)

Comment 3

[Wayne Mery (:wsmwk)]

this was reported in 3.0b4 testing https://litmus.mozilla.org/single_result.cgi?id=206099

Comment 4

[Bryan Clark (DevTools PM) [:clarkbw]]

not sure that this would block the release but it would be good to get fixed and be a bit more consistent in our behaviour.

Comment 5

[Jan Moesen]

Attachment: Replace .focus() by .select()

This fixes the bug/request on my OS X 10.6. The diff is against today's comm-central .dmg; I do not have the whole repository available. Let me know if I need to reformat it.

Comment 6

[Ludovic Hirlimann [:Usul]]

(In reply to comment #5)
> Created an attachment (id=428651) [details]
> Replace .focus() by .select()
> 
> This fixes the bug/request on my OS X 10.6. The diff is against today's
> comm-central .dmg; I do not have the whole repository available. Let me know if
> I need to reformat it.

Please do  - see https://developer.mozilla.org/en/comm-central#Requirements, You'll need to request a specific reviewer to review you patch.

Comment 7

[Jan Moesen]

I tried #thunderbird and #tb-qa for more info, but there was not much activity there. Did you mean I should reformat the patch? If so, could you expand on that (other diff parameters or a Hg diff against the full checked out source)? Or did you mean should I just ask the correct reviewer?

Comment 8

[Ludovic Hirlimann [:Usul]]

Ha sorry I should have answered there. hg diff versus a checked out version is what you need. And then when you attach the new patch make sure to set a request review for someone.

Comment 9

[Jan Moesen]

Attachment: hg diff comm-central/mail/base/content/mailWindowOverlay.js

Comment 10

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 431334 [details] [diff] [review]
hg diff comm-central/mail/base/content/mailWindowOverlay.js

Thank you for the patch!

I have pushed this to the comm-central repo:
http://hg.mozilla.org/comm-central/rev/65ccabf3534a

This should start showing up in 3.1-series nightly builds tomorrow.