Closed Bug 525679 Opened 10 years ago Closed 10 years ago

Remove the bizarre artifact of a separate profile icon for non-Firefox Windows XP

Categories

(Toolkit :: Startup and Profile System, defect)

x86
Windows XP
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1

People

(Reporter: philor, Assigned: philor)

Details

Attachments

(1 file)

Attached patch rmSplinter Review
toolkit/profile/ has a skin/ directory, which is used "for non-Mac non-Phoenix apps." However, since Gnomestripe jars its profileicon.png with a +, it's not used in any app on Linux, and Winstripe has a profileicon-aero.png so it's not used in any app on Vista/Win7, and the CSS is identical between profile/skin/ and themes/winstripe/mozapps/profile/, so practically speaking what it really means is "use a bald icon in a green shirt on Windows XP in Thunderbird and SeaMonkey, instead of the icon in need of a haircut wearing a blue shirt used on Windows XP in Firefox."

Unless you build in a different order, or change the file modification times: I'd think that a make in toolkit/profile/ or toolkit/themes/ would affect which one you get, as would an update to the file in whichever directory builds last.
Attachment #409540 - Flags: review?(benjamin)
Attachment #409540 - Flags: review?(benjamin) → review?(dao)
Attachment #409540 - Flags: review?(dao) → review+
http://hg.mozilla.org/mozilla-central/rev/364c3910daed
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in before you can comment on or make changes to this bug.