525762 - Alt+Tab sometimes causes the menubar to unhide briefly

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch v2

Err, of course I shouldn't use Cc and Ci here.

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch v2

updated to tip

Comment 4

[[e-mail]]

Sorry, but I just haven't been able to reproduce this, either by Alt+Tabbing to another application or to another window in the same Gecko application.

Comment 5

[Dão Gottwald [:dao]]

Can you still review the code? Considering the menubar active in an inactive window doesn't make sense either way.

It happens for me every second try, approximately. But as I said, it's probably system dependent.

Comment 6

[Neil Deakin]

Comment on attachment 424480 [details] [diff] [review]
patch v2

>+      <property name="_isWinActive" readonly="true">
>+        <getter><![CDATA[
>+          var fm = Components.classes["@mozilla.org/focus-manager;1"]
>+                             .getService(Components.interfaces.nsIFocusManager);
>+          return window == fm.activeWindow;

Should we be concerned that this will only work if the <menubar> is in the toplevel window?


>+      <handler event="DOMMenuBarActive"><![CDATA[
>+        // It's possible that we're getting DOMMenuBarActive even if the window
>+        // isn't active anymore because of Alt+Tab.

Isn't that a bug in itself?

I don't see the bug though. DOMMenuBarActive should be sent on keyup, so the menu shouldn't be triggered then. Maybe some locale keyboard difference?

Comment 7

[Dão Gottwald [:dao]]

(In reply to comment #6)
> (From update of attachment 424480 [details] [diff] [review])
> >+      <property name="_isWinActive" readonly="true">
> >+        <getter><![CDATA[
> >+          var fm = Components.classes["@mozilla.org/focus-manager;1"]
> >+                             .getService(Components.interfaces.nsIFocusManager);
> >+          return window == fm.activeWindow;
> 
> Should we be concerned that this will only work if the <menubar> is in the
> toplevel window?

I don't think so... auto-hiding doesn't make sense for other menubars, since Alt wouldn't activate them.

> >+      <handler event="DOMMenuBarActive"><![CDATA[
> >+        // It's possible that we're getting DOMMenuBarActive even if the window
> >+        // isn't active anymore because of Alt+Tab.
> 
> Isn't that a bug in itself?
> 
> I don't see the bug though. DOMMenuBarActive should be sent on keyup, so the
> menu shouldn't be triggered then. Maybe some locale keyboard difference?

I think it's because the event is async and the netbook I'm running Win XP on is rather slow...

Comment 8

[Neil Deakin]

> > I don't see the bug though. DOMMenuBarActive should be sent on keyup, so the
> > menu shouldn't be triggered then. Maybe some locale keyboard difference?
> 
> I think it's because the event is async and the netbook I'm running Win XP on
> is rather slow...

DOMMenuBarActive shouldn't be firing at all.

Can you debug here a bit a find out what menu/popups related events and key events are actually firing when?

Comment 9

[Dão Gottwald [:dao]]

When releasing Alt+Tab quickly, regardless of whether the menu bar shows up, I get these events:

keydown, keyup, deactivate, DOMMenuBarActive, DOMMenuItemActive, DOMMenuBarInactive, DOMMenuItemInactive

If I release Tab and wait a bit before releasing Alt, the menu bar never shows up and I get these events:

keydown, keyup, keyup, deactivate

Comment 10

[[e-mail]]

This is actually a regression of bug 262894 by bug 272847.

Comment 11

[[e-mail]]

Attachment: Proposed patch

Comment 12

[Jim Mathies [:jimm]]

Comment on attachment 434643 [details] [diff] [review]
Proposed patch

oops!

Comment 13

[[e-mail]]

Pushed changeset 91897531cbf5 to mozilla-central.

Comment 14

[[e-mail]]

Comment on attachment 434643 [details] [diff] [review]
Proposed patch

Seeking approval for this simple fix for the branches where the regression typo landed.

Comment 15

[Dão Gottwald [:dao]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a4pre) Gecko/20100326 Minefield/3.7a4pre

Works like a charm.

Comment 16

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 434643 [details] [diff] [review]
Proposed patch

a=beltzner for 1.9.1.10 and 1.9.2.3

Comment 17

[[e-mail]]

Pushed changeset 499f6d27d231 to releases/mozilla-1.9.2

Pushed changeset 0865dc62ccad to releases/mozilla-1.9.1

Comment 18

[Al Billings [:abillings - ex-MoCo]]

Dão can you verify this with the nightly 1.9.2 and 1.9.1 builds since you can reproduce the problem easily?

Comment 19

[Dão Gottwald [:dao]]

Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.9.2.4pre) Gecko/20100413 Namoroka/3.6.4pre

Comment 20

[Dão Gottwald [:dao]]

Cannot verify on 1.9.1, as the menu bar doesn't support auto-hiding there.

Comment 21

[Al Billings [:abillings - ex-MoCo]]

Thanks!