Mozilla Crash Reports header, the button and the advanced link can all go to the right and preserve some vertical space.
Submit button can stay on bottom left, but we should find a way to shorten the height of the form -- query results get pushed too far down.
Removed the redundant title while working in the code in 1.1
Created attachment 421662 [details] [diff] [review] Patch 1 for #525783 Moved the advanced filters and submit button to the right. Verified the form looks properly and works correctly in Firefox, Chrome and Safari.
Attachment #421662 - Flags: review?(ozten.bugs)
Comment on attachment 421662 [details] [diff] [review] Patch 1 for #525783 This changes the layout of the homepage. Can the Webkit bug be fixed without making the query form 1200px? Be sure to test http://rsnyder.khan.mozilla.org/reporter/ and if we have to make a full width query form, then change the layout of the dashboard wigets. css/screen.css - Avoid using px for widths. In some places we replace an em value with a px value.
Attachment #421662 - Flags: review?(ozten.bugs) → review-
Created attachment 421687 [details] [diff] [review] Patch 2 for #525783 I don't think we need to worry about the homepage, because it will be revised in 1.4 - see https://bugzilla.mozilla.org/show_bug.cgi?id=539742 My bad on the 1200px, I had that in there when I was testing a bug and forgot to remove it. I updated the px widths to em widths where appropriate.
Comment on attachment 421687 [details] [diff] [review] Patch 2 for #525783 Nice work. We discussed in IRC that the layout issues introduced in this patch will be fixed in Bug#539742.
Attachment #421687 - Flags: review?(ozten.bugs) → review+
Committed. == Sending application/views/common/query_form.php Sending css/screen.css Transmitting file data .. Committed revision r1699.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
I noticed some broken JS on the query form. jquery was looking for the select with an id of 'branch'. The purpose of this code seems odd: $('#branch').get(0).options.selected = false; So, I've removed to code and will check in with the patch I'm working on.
Component: Socorro → General
Product: Webtools → Socorro
You need to log in before you can comment on or make changes to this bug.