Closed Bug 525809 Opened 16 years ago Closed 5 years ago

Analysis to catch using virtual methods in destructors

Categories

(Developer Infrastructure :: Source Code Analysis, defect)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: bent.mozilla, Unassigned)

Details

Using virtual methods in destructors can be wacky, maybe error (but at least warn) if we have code that does it.
I thought this was already filed but I can't find it. Doing this function-local is of limited benefit, since very often the logic errors happen calling helper methods on the object. I think we could get pretty simple good results with a low false-positive rate if we had the global callgraph.
Yeah, this would be a simple analysis to run as a post-analysis script on a callgraph.
[Tracking Requested - why for this release]:
blocking-b2g: --- → 2.1S?
tracking-b2g: --- → backlog
blocking-b2g: 2.1S? → ---
tracking-b2g: backlog → ---
Product: Core → Firefox Build System

Closing this since we have clang-analyzer-alpha.cplusplus.VirtualCall through clang-tidy.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.