525845 - Some characters in WOFF failed to work on Linux and Solaris

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Ginn Chen]

Some characters in this page are missing.
http://people.mozilla.com/~jkew/woff/udhr-sample/

All the characters in this page are missing.
http://people.mozilla.org/~jdaggett/webfonts/mplus-test.html

The page renders well with Firefox 3.5.

Comment 1

[Ginn Chen]

Tried Firefox 3.6b1 on both x86 and SPARC.
It works fine.

It might be a recent regression.

Comment 2

[Ginn Chen]

Caused by Bug 505284.

It might be reproducible on Linux, too.
But I don't have Linux around right now.

(In reply to comment #0)
> Some characters in this page are missing.
> http://people.mozilla.com/~jkew/woff/udhr-sample/
Forgot to say, select "Downloaded Charis SIL Compact".

Comment 3

[Ginn Chen]

Confirmed on Linux.

Comment 4

[Takuro Ashie [:ashie]]

Attachment: Fix gfxFT2LockedFace::GetGlyph

Sorry, it's my foolish mistake.
gfxFcLockedFace::GetGlyph() in gfxPangoFonts.cpp is never called because gfxFT2FontBase doesn't know gfxFcLockedFace class.

  http://hg.mozilla.org/mozilla-central/file/364c3910daed/gfx/thebes/src/gfxFT2FontBase.cpp#l118
  http://hg.mozilla.org/mozilla-central/file/364c3910daed/gfx/thebes/src/gfxPangoFonts.cpp#l526

Now I've noticed it should be replaced with compile time switch and remove gfxFcLockedFace class.

Comment 5

[Karl Tomlinson (:karlt)]

Comment on attachment 410157 [details] [diff] [review]
Fix gfxFT2LockedFace::GetGlyph

Thank you for following up on this.  This fix looks sensible.

>+#ifdef CAIRO_HAS_FC_FONT

I'm not sure i'm really happy about using CAIRO_HAS_FC_FONT because this doesn't really have anything to do with cairo.  But this is defined at the right times, and anything else would just be duplicating that, so I guess we go with this for now.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 410157 [details] [diff] [review]
Fix gfxFT2LockedFace::GetGlyph

a192=beltzner at dolske's request for WinCE; karlt, maybe file a follow up for your concern?

Comment 7

[Justin Dolske [:Dolske]]

Pushed to 192: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/e90e81d9caf4

Comment 8

[Justin Dolske [:Dolske]]

Oops, noticed this hadn't actually landed on m-c yet.

Pushed http://hg.mozilla.org/mozilla-central/rev/6b694e4f4101

Comment 9

[flo]

Hi, it seems this broke some characters on FreeBSD, an example can be seen here: http://wickedmachine.net/~jsa/FreeBSD/bugs/ff36b3_menu.png this was still present in b4 and we fixed it by going back to gfx/thebes/src/gfxPangoFonts.cpp from b1. How can we help with getting this fixed for the 3.6 release?

Cheers,
Florian

Comment 10

[Karl Tomlinson (:karlt)]

Florian, that sounds like bug 527980.
Can you test b5 or the patch in that bug, please?

Comment 11

[flo]

Yes, it is indeed fixed in b5. Thank you!