525848 - Content tabs don't display "Loading..." string between page loads

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Mark Banner (:standard8)]

There is support for it, but it doesn't quite work, so when clicking through to different pages we don't get the "Loading..." (although we do get the busy indication).

The basic issue is that we're trying to set the tab title to Loading but contentTabType::onTitleChanged is overriding it to the browser title and we probably need to change that to detect if we're loading or not.

Comment 1

[Mark Banner (:standard8)]

Attachment: The fix

Eventually worked this one out. The issue is that when I originally wrote the code and trying to handle DOMTitleChanged I was relying on setTabTitle to call onTitleChanged and handle setting of the title there.

Unfortunately that was wrong, because when we want to set the title to other things we want to set it to the value we're supplying and not be overridden by the document title.

This patch makes us behave the same way as browser.

I don't see an easy test for this as we'd have to reliably delay/detect the network state and check at the right times that the right thing was set. As we've only got access on local network, I'd think that would be difficult.

Comment 2

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/e6c5631dce79