525986 - Wrong combination of :first-line rules and <BR> causes text to disappear

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect, P2)

Description

[Jack Eidsness]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20091102 Minefield/3.7a1pre (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20091102 Minefield/3.7a1pre (.NET CLR 3.5.30729)

I wrote up a test case that causes a failure in minefield but not in normal firefox.  I'll attach it and it's easy to see.  I tested it in safe mode, but haven't tried any other test builds but this one on my PC.

Reproducible: Always

Steps to Reproduce:
1. Load attached HTML test page.
2. Resize window horizontally
Actual Results:  
The text in the after the BR disappears as if it were set display: none.  Well, sometimes the space is filled afterwards, sometimes not, depending on how much resizing you do.

Expected Results:  
Nothing would disappear.  There's nothing in this example to make anything disappear, and the current version of firefox does the right thing.

I suspect there are two incompatible definitions of ":first-line" interacting somehow.  The style seems to be effected correctly, but when the line is ended with a <BR> (starting the other "second line") that text after it goes away.  The same thing happens whether the first line is long enough to wrap around or not.

Comment 1

[Jack Eidsness]

Attachment: HTML example reproducing the problem.

Load this and do a horizontal resize to see some text disappear, incorrectly.

Comment 2

[Jack Eidsness]

If it makes a difference, I'm running this on 64 bit Windows 7.  The build is the same normal 32 bit one I get through the trunk nightly automatic update channel, though.

Comment 3

[philippe (part-time)]

That is a fairly recent regression:
works
Gecko/20091018 Minefield/3.7a1pre
http://hg.mozilla.org/mozilla-central/rev/a176eb500f88
fails
Gecko/20091019 Minefield/3.7a1pre
http://hg.mozilla.org/mozilla-central/rev/d3298de30066

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a176eb500f88&tochange=d3298de30066

--> bug 504524 I think

Comment 4

[Timothy Nikkel (:tnikkel)]

I can't reproduce this and since the last comment bug 523468 has landed which fixed a bunch of regressions caused by bug 504524. So I think this is probably fixed by bug 523468.

Comment 5

[philippe (part-time)]

It is still happening on my Mac with
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20091110 Minefield/3.7a1pre
@rev http://hg.mozilla.org/mozilla-central/rev/f4ef40336cc6

Comment 6

[Timothy Nikkel (:tnikkel)]

My mistake, I wasn't looking closely enough, the testcase still fails.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Fixed by checkin for bug 534366

Comment 8

[Timothy Nikkel (:tnikkel)]

Can we extract an automated test out of the testcase?

Comment 9

[Jack Eidsness]

It's working great, like you said! Thanks!!