526008 - New homepage doesn't validate to its doctype

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Load http://validator.w3.org/check?uri=http%3A%2F%2Fsupport-stage.mozilla.org%2Fen-US%2Fkb%2F&charset=%28detect+automatically%29&doctype=Inline&group=0; we currently have 69 Errors, 61 warning(s).

Comment 1

[James Socol [:jsocol, :james]]

Looks like there are main issues that should clear up almost all of this:
* unescaped ampersands, and
* re-used IDs.

There are also role attributes from bug 519333, but those should go away with bug 526007.

Comment 2

[James Socol [:jsocol, :james]]

Attachment: v1

This makes the new home page (with the mozms2) theme validate as HTML5 (with the patch to bug 526007) and XHTML 1.0 Transitional (without it)--save one error from the ARIA roles.

Comment 3

[James Socol [:jsocol, :james]]

I should add, bug 526638 will need to be fixed to fully clean up the validation errors. But without this patch, fixing that bug will break the layout. (ugh)

Comment 4

[Michael Morgan [:morgamic]]

Comment on attachment 410368 [details] [diff] [review]
v1

This works for me, but there are still errors.  Looks like you're aware of it.

Comment 5

[James Socol [:jsocol, :james]]

r55129

This fixes everything except:
The duplicate IDs from bug 526638.
One role attribute which is an error in XHTML 1.0 but will be fine in HTML5.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; we're down to 4 errors.  A tad bit better than 69 ;-)