526152 - jemalloc alignment assertion and abort on Linux

Status: RESOLVED FIXED

(Core :: Memory Allocator, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

I am getting the following assertion when attempting to start Fennec, a xulrunner based application, on Ubunto 8.10

jemalloc.c:5801: Failed assertion: "((alignment - 1) & alignment) == 0 && alignment >= sizeof(void *)"

Stack looks like this:

Stack:
UNKNOWN [/lib/tls/i686/cmov/libpthread.so.0 +0x0000E618]
abort+0x00000188 [/lib/tls/i686/cmov/libc.so.6 +0x0002D268]
memalign+0x000000AF [../../mobile-debug/mobile/dist/bin/fennec +0x0001FCEA]
__libc_memalign+0x00000042 [/lib/tls/i686/cmov/libc.so.6 +0x00073A42]
___tls_get_addr+0x000000AF [/lib/ld-linux.so.2 +0x0001081F]
UNKNOWN [/home/mfinkle/Source/mozilla-trunk/mobile-debug/mobile/dist/bin/xulrunner/libxul.so +0x01473BAD]
NS_InitXPCOM3_P+0x000000D9 [/home/mfinkle/Source/mozilla-trunk/mobile-debug/mobile/dist/bin/xulrunner/libxul.so +0x0140FBBC]
UNKNOWN [/home/mfinkle/Source/mozilla-trunk/mobile-debug/mobile/dist/bin/xulrunner/libxul.so +0x001CD847]
XRE_main+0x000021BD [/home/mfinkle/Source/mozilla-trunk/mobile-debug/mobile/dist/bin/xulrunner/libxul.so +0x001D3800]
UNKNOWN [../../mobile-debug/mobile/dist/bin/fennec +0x000024AD]
__libc_start_main+0x000000E5 [/lib/tls/i686/cmov/libc.so.6 +0x00016685]

Comment 1

[David Mandelin [:dmandelin]]

Attachment: Patch

Bug analysis for the record: this started asserting because a boolean TLS variable was added, with size == 1 on Ubuntu. jemalloc's memalign asserts that the alignment is at least pointer-width. We can fix just by going up to that size if necessary; the alignment guarantee offered by the memalign API is still upheld.

Comment 2

[David Mandelin [:dmandelin]]

http://hg.mozilla.org/mozilla-central/rev/526ea23c8b21

Comment 4

[Ben Combee (:bcombee)]

I'd love to see this fix moved over to 1.9.2 to make debugging fennec on n900 possible without patch

Comment 5

[Martin Stránský [:stransky] (ni? me)]

I can reproduce in on Fedora12/Firefox 3.6.b3. It would be great to have it in 1.9.2.

Comment 6

[Johnathan Nightingale [:johnath]]

Comment on attachment 410067 [details] [diff] [review]
Patch

Approving this because we believe it's still hurting the ability to debug fennec. If that's stopped being a problem for other reasons, then we should clear this approval rather than adding what looks like workaround code, right?

Comment 7

[Stuart Parmenter]

lets take this, should have done long ago

Comment 8

[LegNeato]

Comment on attachment 410067 [details] [diff] [review]
Patch

a=LegNeato for 1.9.2.5. Please ONLY land this on mozilla-1.9.2 default, as we
are still working on 1.9.2.4 on the relbranch

Comment 9

[David Mandelin [:dmandelin]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/ee1f680f37a1