Closed
Bug 526162
Opened 16 years ago
Closed 16 years ago
The "private" argument to Bug.add_comment should be "is_private" for consistency
Categories
(Bugzilla :: WebService, enhancement)
Bugzilla
WebService
Tracking
()
RESOLVED
FIXED
Bugzilla 3.6
People
(Reporter: mkanat, Assigned: mkanat)
Details
Attachments
(1 file)
|
1.78 KB,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
Bug.add_comment takes a "private" argument. Everywhere else in Bugzilla (and in our future functions) when something is private, we say "is_private" instead of "private". All our booleans, in general, in the WebService, should start with is_ unless there's some good reason to avoid it.
Attached is a patch which modifies this for the sake of future consistency, but maintains backwards-compatibility for things that have to work with multiple versions of Bugzilla.
Attachment #409860 -
Flags: review?(dkl)
|
Assignee | |
Updated•16 years ago
|
Assignee: webservice → mkanat
Status: NEW → ASSIGNED
|
||
Comment 1•16 years ago
|
||
Comment on attachment 409860 [details] [diff] [review]
v1
Looks good and works as expected. r=dkl
Attachment #409860 -
Flags: review?(dkl) → review+
|
|
||
Updated•16 years ago
|
Flags: approval?
|
|
Assignee | |
Comment 2•16 years ago
|
||
Checking in Bugzilla/WebService/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/WebService/Bug.pm,v <-- Bug.pm
new revision: 1.48; previous revision: 1.47
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•