Closed
Bug 526192
Opened 15 years ago
Closed 8 years ago
Don't link against libsoftokn.so
Categories
(Directory :: LDAP C SDK, defect)
Directory
LDAP C SDK
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: glandium, Unassigned)
Details
Attachments
(1 file)
628 bytes,
patch
|
Details | Diff | Splinter Review |
Disclaimer: I'm not sure I should file this under LDAP C SDK, considering this is something I would like to land in Seamonkey, nor who should be reviewing this. LDAP C SDK builds link against the libsoftokn.so file, while this one is supposed to be dynamically loaded. Please note that Windows is not affected because an unrelated change (switching from using -l to using .lib) removed softokn from the list.
Attachment #409902 -
Flags: review?
Reporter | ||
Updated•15 years ago
|
Attachment #409902 -
Flags: review? → review?(anton.bobrov)
Comment 1•15 years ago
|
||
Mark, Rich, any idea why we link against softkn directly ? perhaps historically we had to ? anyway i dont see why we need to link directly against it anymore given that libnss has it as its own dependency. this patch looks good to me.
Comment 2•15 years ago
|
||
(In reply to comment #1) > Mark, Rich, any idea why we link against softkn directly ? perhaps historically > we had to ? anyway i dont see why we need to link directly against it anymore > given that libnss has it as its own dependency. this patch looks good to me. Right. Historically, we had to, otherwise we would get either build time or runtime link errors. I think NSS fixed this a long time ago, so we should not link with softokn anymore.
Reporter | ||
Comment 3•8 years ago
|
||
This is now obsoleted by the move of the c-sdk build system to moz.build in comm-central.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
Reporter | ||
Updated•8 years ago
|
Attachment #409902 -
Flags: review?(anton.bobrov)
You need to log in
before you can comment on or make changes to this bug.
Description
•