526193 - Windows XP, Linux theme inconsistens attachment-deleted, phishing and thread-watched

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[[:Aureliano Buendía]]

Hi Andreas.

I have create a new bug for 4 icons (instead of 4 bugs, for redux the noise) that seems to me that are in old style.

They are locate on chrome\classic\messenger\icons and are:

1. thread-watched.png;
2. attachment-deleted.png;
3. attachment-deleted-large.png;
4. phishing.png.

Probably icon related to be phishing as major impact related to others.

Comment 1

[[:Aureliano Buendía]]

Attachment: phishing icon on linux (same issue on Windows XP)

Comment 2

[[:Aureliano Buendía]]

Attachment: attachment-deleted icon on Linux (same issue on Windows XP)

This issue non is OS related because exist already on Linux and Not only on Windows XP.

Attached 2 screenshots from Linux (Windows XP has same issues).

If Andreas want, I can create 4 different bug for each icon.

Comment 3

[[:Aureliano Buendía]]

Changed OS related and title.

Comment 4

[Andreas Nilsson (:andreasn)]

Where in the UI is  attachment-deleted and attachment-deleted-large used? Do you have any screenshots?

Comment 5

[[:Aureliano Buendía]]

I can change property mailnews.attachments.display.largeView to true using tools-->options-->advanced tab, config editor button...

Comment 6

[[:Aureliano Buendía]]

I'm sorry...
>I can
it is You can :-(

If you want I can provide a screenshot

Comment 7

[Andreas Nilsson (:andreasn)]

It would be great if you could!

Comment 8

[[:Aureliano Buendía]]

Attachment: when mailnews.attachments.display.largeView = true

here you are :-D

Comment 9

[Andreas Nilsson (:andreasn)]

That looks in style with the other icons.

Comment 10

[[:Aureliano Buendía]]

(In reply to comment #9)
> That looks in style with the other icons.
My opinion is this (but it is possible that is wrong):
red "X" in this icon is the same icon that is used in TB 2.x theme for delete action with toolbar button.

In TB 3.x delete icon look different: I think that at least you should change "X" above the paper (see attachment deleted icon and delete icon for button in message header on attached screenshot for difference).

What you think?  ;-)

Comment 11

[Andreas Nilsson (:andreasn)]

ah, yes, good observation!

Patch coming up shortly.

Comment 12

[Andreas Nilsson (:andreasn)]

Attachment: updated icons for gnomestripe and qute

Not sure if the code review is needed really.

Comment 13

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 411928 [details] [diff] [review]
updated icons for gnomestripe and qute

Yeah, I don't think there's anything in there I _can_ review. ;)

So I'm going to go with no r+ needed. (If someone disagrees, I'll be happy to give it a closer look, but nothing appears wrong on the first pass.)

Comment 14

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 411928 [details] [diff] [review]
updated icons for gnomestripe and qute

everything looks pretty good.  The font used for the phishing icon exclamation (!) looks a little thin and jagged to me.  Maybe we could try something else?

Comment 15

[[:Aureliano Buendía]]

need to set keywords to "checkin-needed" ? :-)

Comment 16

[Mark Banner (:standard8)]

Checked into comm-central: http://hg.mozilla.org/comm-central/rev/50fce943a55a

Comment 17

[Mark Banner (:standard8)]

Comment on attachment 411928 [details] [diff] [review]
updated icons for gnomestripe and qute

Patch didn't make 3.0, moving to consider for 3.0.1.

Comment 18

[Andreas Nilsson (:andreasn)]

Attachment: screenshot of the patch to aid 3.0.1 approval

Comment 19

[Rain [:rain1] (inactive)]

Pushed to branch: http://hg.mozilla.org/releases/comm-1.9.1/rev/8d3229dedd6b