Closed Bug 526193 Opened 12 years ago Closed 12 years ago

Windows XP, Linux theme inconsistens attachment-deleted, phishing and thread-watched

Categories

(Thunderbird :: Mail Window Front End, defect)

x86
All
defect
Not set
minor

Tracking

(thunderbird3.0 .1-fixed)

VERIFIED FIXED
Thunderbird 3.1a1
Tracking Status
thunderbird3.0 --- .1-fixed

People

(Reporter: Aureliano, Assigned: andreasn)

References

(Blocks 1 open bug)

Details

(Keywords: polish)

Attachments

(5 files)

Hi Andreas.

I have create a new bug for 4 icons (instead of 4 bugs, for redux the noise) that seems to me that are in old style.

They are locate on chrome\classic\messenger\icons and are:

1. thread-watched.png;
2. attachment-deleted.png;
3. attachment-deleted-large.png;
4. phishing.png.

Probably icon related to be phishing as major impact related to others.
Blocks: 488061
This issue non is OS related because exist already on Linux and Not only on Windows XP.

Attached 2 screenshots from Linux (Windows XP has same issues).

If Andreas want, I can create 4 different bug for each icon.
Changed OS related and title.
OS: Windows XP → All
Summary: Windows XP theme inconsistens attachment-deleted, phishing and thread-watched → Windows XP, Linux theme inconsistens attachment-deleted, phishing and thread-watched
Where in the UI is  attachment-deleted and attachment-deleted-large used? Do you have any screenshots?
Assignee: nobody → nisses.mail
I can change property mailnews.attachments.display.largeView to true using tools-->options-->advanced tab, config editor button...
I'm sorry...
>I can
it is You can :-(

If you want I can provide a screenshot
It would be great if you could!
here you are :-D
That looks in style with the other icons.
(In reply to comment #9)
> That looks in style with the other icons.
My opinion is this (but it is possible that is wrong):
red "X" in this icon is the same icon that is used in TB 2.x theme for delete action with toolbar button.

In TB 3.x delete icon look different: I think that at least you should change "X" above the paper (see attachment deleted icon and delete icon for button in message header on attached screenshot for difference).

What you think?  ;-)
ah, yes, good observation!

Patch coming up shortly.
Not sure if the code review is needed really.
Attachment #411928 - Flags: ui-review?(clarkbw)
Attachment #411928 - Flags: review?(bwinton)
Comment on attachment 411928 [details] [diff] [review]
updated icons for gnomestripe and qute

Yeah, I don't think there's anything in there I _can_ review. ;)

So I'm going to go with no r+ needed. (If someone disagrees, I'll be happy to give it a closer look, but nothing appears wrong on the first pass.)
Attachment #411928 - Flags: review?(bwinton)
Whiteboard: [needs review clarkbw]
Attachment #411928 - Flags: ui-review?(clarkbw) → ui-review+
Comment on attachment 411928 [details] [diff] [review]
updated icons for gnomestripe and qute

everything looks pretty good.  The font used for the phishing icon exclamation (!) looks a little thin and jagged to me.  Maybe we could try something else?
Attachment #411928 - Flags: approval-thunderbird3?
Whiteboard: [needs review clarkbw]
Whiteboard: [has review+]
need to set keywords to "checkin-needed" ? :-)
Checked into comm-central: http://hg.mozilla.org/comm-central/rev/50fce943a55a
Status: NEW → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [has review+]
Target Milestone: --- → Thunderbird 3.1a1
Comment on attachment 411928 [details] [diff] [review]
updated icons for gnomestripe and qute

Patch didn't make 3.0, moving to consider for 3.0.1.
Attachment #411928 - Flags: approval-thunderbird3?
Attachment #411928 - Flags: approval-thunderbird3.0.1?
Attachment #411928 - Flags: approval-thunderbird3-
Blocks: 533194
Attachment #411928 - Flags: approval-thunderbird3.0.1? → approval-thunderbird3.0.1+
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.