erroneously multiple tabs restored based on that day browsing history on crash recovery without prompt

RESOLVED INVALID

Status

()

Firefox
Session Restore
RESOLVED INVALID
9 years ago
9 years ago

People

(Reporter: karthikatindia, Unassigned)

Tracking

3.5 Branch
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

9 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.4) Gecko/20091016 Firefox/3.5.4 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.4) Gecko/20091016 Firefox/3.5.4 (.NET CLR 3.5.30729)

I was using the browser for nearly 6 hours without closing. At one point, I had the browser hung for long time. I used the windows task manager to kill the process. On reopening the firefox, it doesn't showed me the usual session restore UI where you can pick the tabs you wish to restore. But instead, it just opened whatever tabs I saw on that day in multiple browser windows without any prompt.

Reproducible: Sometimes

Steps to Reproduce:
1.browse for some long time(probably short time but multiple site visits)
2.at times, when your browser hung for some reason, close the browser process using windows task manager kill option
3.now open the browser again
Actual Results:  
you will likely stumble upon loads of individual windows loading all the things that you saw in your last browsing session

Expected Results:  
it should have shown session restore UI where one can select what tab one wish to choose

Build platform
target
i686-pc-mingw32

Build tools
Compiler 	Version 	Compiler flags
cl 	14.00.50727.762 	-TC -nologo -W3 -Gy -Fdgenerated.pdb -DNDEBUG -DTRIMMED -Zi -UDEBUG -DNDEBUG -GL -wd4624 -wd4952 -O1
cl 	14.00.50727.762 	-GR- -TP -nologo -Zc:wchar_t- -W3 -Gy -Fdgenerated.pdb -DNDEBUG -DTRIMMED -Zi -UDEBUG -DNDEBUG -GL -wd4624 -wd4952 -O1

Configure arguments
--enable-application=browser --enable-update-channel=release --enable-update-packaging --enable-jemalloc --enable-official-branding --with-crashreporter-enable-percent=10
This is actually expected behavior. This is controlled via a pref (browser.sessionstore.max_resumed_crashes). The default value is 1, meaning that we'll restore one crash normally, but on the 2nd consecutive crash, you'll get the crash restore UI. Setting that pref to 0 should force the UI on the first crash.

If you'd like to argue that the default value should be 0, there's probably a bug on that. Take a look through session restore bugs and comment there. If you can't find one, file a new bug.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → WORKSFORME
(Reporter)

Comment 2

9 years ago
Thank you. I'm okay if this restore logic is a controlled one just like controlled nuclear explosion ;-)

but one point that itches my head was, when the browser crashed I had max only 2 or 3 tabs opened. But on restore, it opened nearly 20 windows. those restored are sites I have gone through on that day along. Is this how the crash should restore?? all the days tabs? or tabs left opened at the moment of crash? 

thanks again for your time looking into this.

(In reply to comment #1)
> This is actually expected behavior. This is controlled via a pref
> (browser.sessionstore.max_resumed_crashes). The default value is 1, meaning
> that we'll restore one crash normally, but on the 2nd consecutive crash, you'll
> get the crash restore UI. Setting that pref to 0 should force the UI on the
> first crash.
> 
> If you'd like to argue that the default value should be 0, there's probably a
> bug on that. Take a look through session restore bugs and comment there. If you
> can't find one, file a new bug.
Status: RESOLVED → UNCONFIRMED
Resolution: WORKSFORME → ---

Updated

9 years ago
Severity: normal → critical
Keywords: crash
(In reply to comment #2)
> but one point that itches my head was, when the browser crashed I had max only
> 2 or 3 tabs opened. But on restore, it opened nearly 20 windows. those restored
> are sites I have gone through on that day along. Is this how the crash should
> restore?? all the days tabs? or tabs left opened at the moment of crash? 

If you've changed your save interval (as the internet went crazy about a couple months ago) then what's on disk will be old. Normal quits save the most recent data. Killing the process does not. Check your browser.sessionstore.interval value - it's in milliseconds and the default of 10000 = 10s.

If you have a reasonable value (and did at the time of this problem), and can reproduce, please reopen this bug and we'll make it about that issue.
Severity: critical → normal
Status: UNCONFIRMED → RESOLVED
Last Resolved: 9 years ago9 years ago
Keywords: crash
OS: Windows Vista → All
Hardware: x86 → All
Resolution: --- → INVALID
Version: unspecified → 3.5 Branch
You need to log in before you can comment on or make changes to this bug.