Don't morph when not needed in GetWrapperForObject

RESOLVED FIXED in mozilla1.9.3a1

Status

()

Core
XPConnect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: peterv, Assigned: peterv)

Tracking

Trunk
mozilla1.9.3a1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 years ago
Created attachment 409915 [details] [diff] [review]
v1
Attachment #409915 - Flags: review?(mrbkap)
Comment on attachment 409915 [details] [diff] [review]
v1

At the very least, this will clean up your console some :-).
Attachment #409915 - Flags: review?(mrbkap) → review+
(Assignee)

Comment 2

8 years ago
Created attachment 410194 [details] [diff] [review]
v1.1

Bah, that wasn't enough because we call wrapper->NeedsChromeWrapper() further down. If a wrapper is a slim wrapper and we morph then NeedsChromeWrapper would return false anyway, so checking for a non-null wrapper first should be fine.
Attachment #409915 - Attachment is obsolete: true
Attachment #410194 - Flags: review?(mrbkap)

Updated

8 years ago
Attachment #410194 - Flags: review?(mrbkap) → review+
Comment on attachment 410194 [details] [diff] [review]
v1.1

I can't wait until my patch that renames NeedsChromeWrapper -> WantsSOWs lands. Sorry for missing this before.
(Assignee)

Comment 4

8 years ago
http://hg.mozilla.org/mozilla-central/rev/2f5d97dd7e56
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in before you can comment on or make changes to this bug.