Closed
Bug 526201
Opened 16 years ago
Closed 16 years ago
Don't morph when not needed in GetWrapperForObject
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: peterv, Assigned: peterv)
Details
Attachments
(1 file, 1 obsolete file)
|
1.58 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #409915 -
Flags: review?(mrbkap)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 409915 [details] [diff] [review]
v1
At the very least, this will clean up your console some :-).
Attachment #409915 -
Flags: review?(mrbkap) → review+
|
Assignee | |
Comment 2•16 years ago
|
||
Bah, that wasn't enough because we call wrapper->NeedsChromeWrapper() further down. If a wrapper is a slim wrapper and we morph then NeedsChromeWrapper would return false anyway, so checking for a non-null wrapper first should be fine.
Attachment #409915 -
Attachment is obsolete: true
Attachment #410194 -
Flags: review?(mrbkap)
|
|
||
Updated•16 years ago
|
Attachment #410194 -
Flags: review?(mrbkap) → review+
|
|
||
Comment 3•16 years ago
|
||
Comment on attachment 410194 [details] [diff] [review]
v1.1
I can't wait until my patch that renames NeedsChromeWrapper -> WantsSOWs lands. Sorry for missing this before.
|
|
Assignee | |
Comment 4•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in
before you can comment on or make changes to this bug.
Description
•