526246 - Fatal error accessing tiki-admin_modules.php on support-stage

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect)

Description

[Chris Ilias [:cilias]]

Go to <https://support-stage.mozilla.org/tiki-admin_modules.php?um_edit=promotebox>.

I get an error message:
Fatal error: Maximum execution time of 30 seconds exceeded in /data/www/support-stage.mozilla.com/webroot/lib/smarty_tiki/outputfilter.urlt.php  on line 132

Comment 1

[Paul Craciunoiu [:paulc]]

A good solution is to remove those selects and replace them by inputs, as Cheng said in our meeting today. This is also a tiki bug, since for a large number of a certain type of content, it should limit the items displayed.

Comment 2

[Paul Craciunoiu [:paulc]]

Attachment: v1

This patch removes all the listing for polls and other contents. Reduces the page load time from ~18s to <1s on my local.

Of course this is not upstream-able. To help a bit, I suppose we could create a template in mozkb/ instead of hacking the original one. James, what do you think?

Comment 3

[James Socol [:jsocol, :james]]

Paul, I'd prefer if you could make the copy, since it's pretty much just a copy/paste/svn add.

Comment 4

[Paul Craciunoiu [:paulc]]

Attachment: v2

This adds a new template and delete code not used in the template. Testing without removing the php code still leads to >5s page load time, so affecting the .php file seems necessary.

Comment 5

[James Socol [:jsocol, :james]]

Comment on attachment 410564 [details] [diff] [review]
v2

WFM. I'm still able to create & edit modules but without all the extra junk. Mine wasn't timing out locally, but it does seem snappier now.

Comment 6

[Paul Craciunoiu [:paulc]]

r55333
Should be a lot better now.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://support-stage.mozilla.org/tiki-admin_modules.php?um_edit=promotebox; seems to be fine so far.

Comment 8

[Louis-Philippe Huberdeau]

Yet an other case of code removal.

My understanding is that is is caused by the large amount of polls.

An option could be to add filters and pagination as it was done on the category admin. Simply removing the code is not really an option.

Comment 9

[Paul Craciunoiu [:paulc]]

I think the way to ensure you don't have these types of problems is to not list all content of any type in a single select box, but instead use search -- and break it down into pages as you said.

That said, there are several places in the code that list all wiki articles or polls in a single <select> -- see bug 526786 for removing those and replacing them wish something better (search or pagination).

Comment 10

[Louis-Philippe Huberdeau]

pagination applied