Closed Bug 526264 Opened 10 years ago Closed 10 years ago

'No timezones found' error during startup, calendars not visible

Categories

(Calendar :: Lightning Only, defect, critical)

defect
Not set
critical

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ssitter, Assigned: ssitter)

References

Details

(Keywords: regression)

Attachments

(1 file)

It looks like something in the patch for Bug 470430 broke Lightning 1.0pre. If you install the 20091103 build into an existing profile it fails with timezone errors on the next startup:

[calTimezoneService] using D:\dev\apps\thunderbird\extensions\calendar-timezones@mozilla.org\timezones.sqlite

Error: No timezones found! Please install calendar-timezones.xpi.

Error: [Exception... "'<error>' when calling method: [calICalendar::uri]"  nsresult: "0x804a0008 (<unknown>)"  location: "JS frame :: file:///[...]/calendar-js/calCalendarManager.js :: cmgr_createCalendar :: line 613"  data: no]

Error: uncaught exception: [Exception... "'[JavaScript Error: "this.mSelectByTzid is undefined" {file: "file:///[...]/calendar-js/calTimezoneService.js" line: 237}]' when calling method: [calITimezoneService::defaultTimezone]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://calendar/content/calUtils.js :: calendarDefaultTimezone :: line 212"  data: yes]
I think the problem might be caused by this cleanup:

> -  var extMgr = Components.classes["@mozilla.org/extensions/manager;1"]
> +  let extMgr = Components.classes["@mozilla.org/extensions/manager;1"]

http://hg.mozilla.org/releases/comm-1.9.1/annotate/0e1adb3b9ac8/calendar/base/src/calTimezoneService.js#l146

But extMgr is later accessed outside this scope and fails.
Attached patch bustage fixSplinter Review
Assignee: nobody → ssitter
Status: NEW → ASSIGNED
Attachment #409967 - Flags: review?(philipp)
Comment on attachment 409967 [details] [diff] [review]
bustage fix

Looks good. If this is not it, did you remove the stray extensions directory as noted in bug 470430?
Attachment #409967 - Flags: review?(philipp) → review+
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/1533f0738a3a>
and comm-1.9.1 <http://hg.mozilla.org/releases/comm-1.9.1/rev/520d6289316f>

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
(In reply to comment #3)
> If this is not it, did you remove the stray extensions directory as
> noted in bug 470430?

I did not found this directory on my system and it is not related to this bug. This bug occurs because we access undefined |extMgr| in case of Lightning, trigger an exception and fallback to the unit test section in the code linked above.
Duplicate of this bug: 526419
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.4pre) Gecko/20090915 Lightning/1.0pre Thunderbird/3.0b4... Lightning build id: 20091104034447
Status: RESOLVED → VERIFIED
Duplicate of this bug: 526617
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.