Closed Bug 526286 Opened 15 years ago Closed 15 years ago

Detaching a tab by dragging it down into its content area stopped working

Categories

(Core :: DOM: Copy & Paste and Drag & Drop, defect, P2)

Product:
Core
Component:
DOM: Copy & Paste and Drag & Drop
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.3a1
Tracking Flags:
Tracking Status
status1.9.2 --- beta2-fixed

People

(Reporter: bzbarsky, Assigned: smaug)

References

Details

(Keywords: regression, verified1.9.2)

Attachments

(3 files)

patch
2.19 KB, patch
enndeakin
: review+
sicking
: superreview+
Details | Diff | Splinter Review
tests
2.43 KB, patch
Details | Diff | Splinter Review
for 1.9.2
4.82 KB, patch
Details | Diff | Splinter Review 
This is a regression from bug 508479 (based on regression date range and observed behavior).  I was somewhat unpleasantly surprised by it when I updated, since now the only way to detach a tab is to drag it completely out of the window; in particular if the browser happens to be maximized there's no way to detach a tab at all.
Flags: blocking1.9.2?
also confirmed in 1.9.2 nightlies.
Assignee: nobody → Olli.Pettay
windows build is not working also
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2b2pre) Gecko/20091103 Namoroka/3.6b2pre ID:20091103045100
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a1pre) Gecko/20091103 Minefield/3.7a1pre ID:20091103044839
Yeah, I know what caused this. Just updating my build and will upload
a (hopefully) trivial patch.
Attached patch patch — — Splinter Review 
Bring back the old behavior of nsContentAreaDragDrop, but
don't dispatch non-prevented-drops to content.
Attachment #410028 - Flags: superreview?(jonas)
Attachment #410028 - Flags: review?(enndeakin)
No automatic tests for this, not at least today.
Comment on attachment 410028 [details] [diff] [review]
patch

Needs tests!
Attachment #410028 - Flags: superreview?(jonas) → superreview+
Attached patch tests — — Splinter Review 
A bit hackish test, based on just the flags dragsession have.
Attachment #410028 - Flags: review?(enndeakin) → review+
Blocking on this blocker regression.
Flags: blocking1.9.2? → blocking1.9.2+
Priority: -- → P2
Target Milestone: --- → mozilla1.9.2
Flags: in-litmus?
Attached patch for 1.9.2 — — Splinter Review 

    
    

    
  
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/92da2df9a3e9
Status: NEW → RESOLVED
Closed: 15 years ago

          status1.9.2:
          --- → final-fixed
Resolution: --- → FIXED

    
  
OS: Mac OS X → All
Hardware: x86 → All

    
    

    
  
Olli, are the tests complete then?
Flags: in-testsuite?
Target Milestone: mozilla1.9.2 → mozilla1.9.3a1

    
    

    
  
Some better tests would be good, but the tests I pushed do check for this
particular regression.

    
    

    
  
Thanks so we are ok here. Also the following litmus test covers this particular issue: https://litmus.mozilla.org/show_test.cgi?id=9252
Flags: in-testsuite?
Flags: in-testsuite+
Flags: in-litmus?
Flags: in-litmus+

    
    

    
  
Verified fixed on the 1.9.2 branch using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2b2pre) Gecko/20091106 Namoroka/3.6b2pre. Also checked equivalent builds on Windows 7, Windows Vista, Mac 10.4 and 10.5
Whiteboard: verified1.9.2

    
    

    
  
Looks good on trunk too with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20091106 Minefield/3.7a1pre ID:20091106102904

Fixing keyword...
Status: RESOLVED → VERIFIED
Keywords: verified1.9.2
Whiteboard: verified1.9.2

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: