526301 - [FyFx] Language detection only takes the first component of Accept Language header

Status: RESOLVED FIXED

(Webtools Graveyard :: Five Years of Firefox, defect)

Description

[Staś Małolepszy :stas]

The language detection in http://viewvc.svn.mozilla.org/vc/projects/fyfx/trunk/index.php?revision=54729&view=markup only takes into account the first component of Accept Language header. 

$lang = explode("-", $iso_lang[0]);

We should support falling back to other locales than en-US. We could use an existing solution, e.g. from mozilla.com:

http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/trunk/includes/prefetch.php?revision=54633&view=markup#l79

http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/trunk/includes/langconfig.inc.php?view=markup

Comment 1

[Staś Małolepszy :stas]

Or from AMO:

http://viewvc.svn.mozilla.org/vc/addons/trunk/site/app/config/language.php?view=markup#l88

Comment 2

[Staś Małolepszy :stas]

Attachment: correctly detect locale

This patch uses the Mozilla.com code to correctly detect the locale. It also fixes bug 526305 by registering the locale for gettext using the correct system name (e.g. "fa" gets registered as "fa_IR.utf8").

I'm going to land this asap to allow localizers to preview and test their work.

Comment 3

[Staś Małolepszy :stas]

Landed in r55073. Some further tweaks to the list of supported locales <http://viewvc.svn.mozilla.org/vc/projects/fyfx/trunk/components/locales.inc.php?view=markup&pathrev=55073> might be needed.