Closed Bug 526429 Opened 12 years ago Closed 6 years ago

Theme preview should be made branding-aware or branding-agnostic

Categories

(Thunderbird :: Theme, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 38.0

People

(Reporter: glandium, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

The thunderbird themes preview.png currently include the Thunderbird name, making the png branding-dependent. It should either be made
branding-aware (possibility to change it through --with-branding directory), or
branding-agnostic (removing the name from the preview image).
Mass move to the new theme component.
Component: General → Theme
QA Contact: general → theme
Attached patch themePreview.patch (obsolete) β€” β€” Splinter Review
Like Firefox I removed the previews which are anyway outdated. The icon is now the monochrome TB-bird like the FX logo. The icon64.png is for details pane in Add-on manager.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8541912 - Flags: review?(josiah)
Some potentially relevant stuff discussed on IRC:

14:52:10 - JosiahOne: Do you think you could get the shadowing closer to the Fx one? So it looks like the icon is "ingrained" within the background.
14:52:56 - JosiahOne: Paenglab: Also, I feel like it needs some component of the envelope. Maybe just the outline of the bottom.
...
14:53:18 - JosiahOne: Similar to how Fx has the top of the globe.
...
14:55:24 - Paenglab: JosiahOne: For the Fx icon, it's the tail and not the globe.
14:56:43 - JosiahOne: Paenglab: The very top? http://cl.ly/Z78d
14:57:10 - JosiahOne: I guess it sort of is. It's hard to tell.
14:57:29 - Paenglab: Okay, maybe the globe ;)
14:58:16 - JosiahOne: Regardless, right now the TB icon looks like it has a cutout in it, since the envelope was removed. I think it might look nicer with the bottom of the envelope.
Attached patch themePreview.patch β€” β€” Splinter Review
Okay, this is what I can do with my experience. I added a wireframe of the letter to close the icon circle a bit.
Attachment #8541912 - Attachment is obsolete: true
Attachment #8541912 - Flags: review?(josiah)
Attachment #8541957 - Flags: review?(josiah)
Comment on attachment 8541957 [details] [diff] [review]
themePreview.patch

Review of attachment 8541957 [details] [diff] [review]:
-----------------------------------------------------------------

That's much better, and I can't do any better, so let's just go ahead with this and hope it lures in designers. :)
Attachment #8541957 - Flags: review?(josiah) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/4c8ddb16d3b3 -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 38.0
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.