526555 - ProfileManager does not delete profiles

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Armen [:armenzg]]

Mozilla/5.0 (X11; U; Linux armv6l; de; (even though it is a multi-locale build) rv:1.9.2b2pre) Gecko/20091104 Firefox/3.6b2pre Fennec/1.0b5

1) fennec --ProfileManager
2) Create profile(s)
3) Try to delete it them

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

The profile manager is trying to display a prompt, confirming you wish to delete the profile, but it fails.

It's actually a problem with our nsPromptService. Our service uses code in the browser.xul file to work. But when the profilemanager window is open, browser.xul has not opened, so we get errors.

We should probably pass through the the toolkit method (or service) to show prompts when Fennec itself is not running.

Comment 2

[Fabrice Desré]

Attachment: fix

This patch :
- uses the overridden component when the main window is not yet opened.

- fixes a bug in select.xul introduced when adding support for VK_ESCAPE and VK_RETURN

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 410454 [details] [diff] [review]
fix


>-  openDialog: function(parent, src, params) {
>+  openDialog: function(aParent, src, params) {

Update the other two arguments too

>   alert: function(aParent, aTitle, aText) {
>+    let doc = this.getDocument();
>+    if (!doc) {
>+      let ps = Components.classesByID["{a2112d6a-0e28-421f-b46a-25c0B308cbd0}"].
>+                            getService(Ci.nsIPromptService); 
>+      ps.alert(aParent, aTitle, aText);
>+    }

Add a helper function to get the standard prompt service (_getFallback or something)

>   confirmEx: function(aParent, aTitle, aText, aButtonFlags, aButton0,
>             aButton1, aButton2, aCheckMsg, aCheckState) {
>     let numButtons = 0;
>     let titles = [aButton0, aButton1, aButton2];
>-    

Some whitespace is good!

>   commonPrompt : function(aParent, aTitle, aText, aValue, aCheckMsg, aCheckState, isPassword) {
>     var params = new Object();
>     params.result = false;
>     params.checkbox = aCheckState;
>     params.value = aValue;
>+    let doc = this.getDocument();
>+    if (!doc) {
>+      throw "No document !";
>+    }

Could move this above the param code block. Make sure you have a blank line after it :)

Comment 4

[Fabrice Desré]

Attachment: updated fix

Addressed comment #3

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

I can delete profiles again!

pushed:
https://hg.mozilla.org/mobile-browser/rev/d530b0a18392

Comment 7

[[:Aleksej]]

Verified fixed (deleting and renaming) with the todays nightly builds for Linux x86 on Debian GNU/Linux.