Closed Bug 526620 Opened 15 years ago Closed 9 years ago

Resizing window to a small size -> taskbar preview small -> Restore window -> taskbar preview still small until hoverd over

Categories

(Firefox :: Shell Integration, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 38

People

(Reporter: u88484, Assigned: robarnold)

References

Details

Attachments

(1 file, 2 obsolete files)

Resizing window to a small size -> taskbar preview small -> Restore window -> taskbar preview still small until hoverd over.

STR:
1) Load any page in at least two tabs
2) Resize the window so that about 15 pixels are showing
3) Look at taskbar preview and notice a few pixels of the preview are shown
4) Restore the window to the maximized size
5) Look at the preview and notice the taskbar preview is still small until you hover over the preview
Still small in the inactive tab
Unlike bug 526618, IE does this right and does not show this behavior.
So the problem here I think is that we don't resize background tabs.
Assignee: nobody → tellrob
Status: NEW → ASSIGNED
Attachment #447672 - Flags: review?(rflint)
Attachment #447672 - Flags: review?(rflint) → review?(gavin.sharp)
Unbitrotted, switching reviewers to Dao
Attachment #447672 - Attachment is obsolete: true
Attachment #484530 - Flags: review?(dao)
Attachment #447672 - Flags: review?(gavin.sharp)
Comment on attachment 8546458 [details] [diff] [review]
[rebased] Intelligently invalidate other tabs' previews on resize, flushing their layout when necessary

Review of attachment 8546458 [details] [diff] [review]:
-----------------------------------------------------------------

Worked perfectly for me after numerous resize -> check the thumbs -> resize ... loops.

::: browser/modules/WindowsPreviewPerTab.jsm
@@ +202,5 @@
>  
>    // Resizes the canvasPreview to 0x0, essentially freeing its memory.
>    // updateCanvasPreview() will detect the size mismatch as a resize event
>    // the next time it is called.
> +  resetCanvasPreview: function () this.resizeCanvasPreview(0, 0),

This is a one line function without paren? I didn't know you could do this.
Attachment #8546458 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/mozilla-central/rev/38fb85296699
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
Depends on: 1127577
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: