526635 - Interfaces changed on the 1.9.2 branch with no IID rev

Status: RESOLVED FIXED

Description

[Dave Townsend [:mossop] (he/him)]

Going to post a bunch of patchs to track the issues found by bug 477166

Comment 1

[Dave Townsend [:mossop] (he/him)]

Created attachment 410367 [details] [diff] [review]
rev for bug 500889 [1.9.2 branch only]

Comment 2

[Dave Townsend [:mossop] (he/him)]

Created attachment 410369 [details] [diff] [review]
rev for bug 463088

Comment 3

[Dave Townsend [:mossop] (he/him)]

Created attachment 410371 [details] [diff] [review]
rev for bug 515354

Comment 4

[Dave Townsend [:mossop] (he/him)]

Created attachment 410373 [details] [diff] [review]
rev for bug 489864

Bug 489864 revved the IID for the wrong interface. This undoes that rev and updates the correct one.

Comment 5

[Dave Townsend [:mossop] (he/him)]

Created attachment 410375 [details] [diff] [review]
rev for bug 484033

Comment 6

[Dave Townsend [:mossop] (he/him)]

Created attachment 410376 [details] [diff] [review]
rev for bug 510110

Comment 7

[Dave Townsend [:mossop] (he/him)]

Created attachment 410378 [details] [diff] [review]
rev for bug 498130

Comment 8

[Dave Townsend [:mossop] (he/him)]

Created attachment 410381 [details] [diff] [review]
rev for bug 503025 [1.9.2 branch only]

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 410376 [details] [diff] [review]
rev for bug 510110

OK

We probably don't want to change IIDs on some of the other interfaces, now that it's post-beta, but this one should be OK.

Comment 10

[Ted Mielczarek [:ted] [:ted.mielczarek]]

Comment on attachment 410375 [details] [diff] [review]
rev for bug 484033

Crap, did I forget to rev that? Sorry!

Comment 11

[Neil Deakin]

Comment on attachment 410369 [details] [diff] [review]
rev for bug 463088

I'm assuming this change will be made on trunk too.

Comment 12

[Marco Bonardo [::mak]]

Comment on attachment 410378 [details] [diff] [review]
rev for bug 498130

Thank you for catching this, i also assume this will also land on trunk.

Comment 13

[Dave Townsend [:mossop] (he/him)]

Landed the patches that are also applicable to trunk there: http://hg.mozilla.org/mozilla-central/rev/2fccec04a391

Comment 14

[Dave Townsend [:mossop] (he/him)]

Created attachment 410835 [details] [diff] [review]
combined branch patch

This is the combined branch patch that we should land as soon as possible.

Comment 15

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 410835 [details] [diff] [review]
combined branch patch

If we must...

Can you give the list of interfaces to Nick and co, so they can inform add-on devs as needed?

Comment 16

[Dave Townsend [:mossop] (he/him)]

landed on branch, Nick and Sheppy emailed: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/589f15789250

Comment 17

[Eric Shepherd [:sheppy]]

Added a temporary section to the Firefox 3.6 for developers page; it'll be removed before Fx 3.6 goes final.

https://developer.mozilla.org/en/Firefox_3.6_for_developers#IID_changes_between_beta_1_and_beta_2