Closed
Bug 526667
Opened 15 years ago
Closed 15 years ago
importDialog() doesn't clean up empty text nodes
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
fennec1.0
People
(Reporter: fabrice.desre, Assigned: fabrice.desre)
Details
Attachments
(1 file, 1 obsolete file)
|
2.91 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
When loading a dialog, we must remove empty text nodes as make the XUL document loader. Without that, some indented elements (like menulists) fail to render
|
Assignee | |
Comment 1•15 years ago
|
||
Same code than the one used to load add-on options, excpet taht we check for emptyness of text nodes (this should probably be fixed also for add-ons options)
Attachment #410408 -
Flags: review?(mark.finkle)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 410408 [details] [diff] [review] patch Two things: 1. We don't need to use the removeTextNode function, right? Let's just make the code in the current function and skip the function call. 2. Make the same changes to extensions.xml Otherwise, looks good. I just want the code synced.
Attachment #410408 -
Flags: review?(mark.finkle) → review-
|
|
Assignee | |
Comment 3•15 years ago
|
||
Addressed comment #2, with the same fix in bindings/extensions.xml
Attachment #410408 -
Attachment is obsolete: true
Attachment #411991 -
Flags: review?(mark.finkle)
|
|
||
Updated•15 years ago
|
Attachment #411991 -
Flags: review?(mark.finkle) → review+
|
|
||
Comment 4•15 years ago
|
||
pushed: https://hg.mozilla.org/mobile-browser/rev/e5cef5d4a4d2
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•15 years ago
|
Hardware: x86 → All
Target Milestone: --- → Post-B5
You need to log in
before you can comment on or make changes to this bug.
Description
•