Closed Bug 526667 Opened 10 years ago Closed 10 years ago

importDialog() doesn't clean up empty text nodes

Categories

(Firefox for Android Graveyard :: General, defect)

Fennec 1.1
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
fennec1.0

People

(Reporter: fabrice.desre, Assigned: fabrice.desre)

Details

Attachments

(1 file, 1 obsolete file)

When loading a dialog, we must remove empty text nodes as make the XUL document loader. Without that, some indented elements (like menulists) fail to render
Attached patch patch (obsolete) — Splinter Review
Same code than the one used to load add-on options, excpet taht we check for emptyness of text nodes (this should probably be fixed also for add-ons options)
Attachment #410408 - Flags: review?(mark.finkle)
Comment on attachment 410408 [details] [diff] [review]
patch

Two things:
1. We don't need to use the removeTextNode function, right? Let's just make the code in the current function and skip the function call.

2. Make the same changes to extensions.xml

Otherwise, looks good. I just want the code synced.
Attachment #410408 - Flags: review?(mark.finkle) → review-
Attached patch updated fixSplinter Review
Addressed comment #2, with the same fix in bindings/extensions.xml
Attachment #410408 - Attachment is obsolete: true
Attachment #411991 - Flags: review?(mark.finkle)
Attachment #411991 - Flags: review?(mark.finkle) → review+
pushed:
https://hg.mozilla.org/mobile-browser/rev/e5cef5d4a4d2
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Hardware: x86 → All
Target Milestone: --- → Post-B5
You need to log in before you can comment on or make changes to this bug.