Closed Bug 526667 Opened 10 years ago Closed 10 years ago
Dialog() doesn't clean up empty text nodes
When loading a dialog, we must remove empty text nodes as make the XUL document loader. Without that, some indented elements (like menulists) fail to render
Same code than the one used to load add-on options, excpet taht we check for emptyness of text nodes (this should probably be fixed also for add-ons options)
Attachment #410408 - Flags: review?(mark.finkle)
Comment on attachment 410408 [details] [diff] [review] patch Two things: 1. We don't need to use the removeTextNode function, right? Let's just make the code in the current function and skip the function call. 2. Make the same changes to extensions.xml Otherwise, looks good. I just want the code synced.
Attachment #410408 - Flags: review?(mark.finkle) → review-
Addressed comment #2, with the same fix in bindings/extensions.xml
Attachment #411991 - Flags: review?(mark.finkle) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Hardware: x86 → All
Target Milestone: --- → Post-B5
You need to log in before you can comment on or make changes to this bug.