526672 - Visiting PluginCheck page from a notificationbar should reset notifyUser pref

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

When the PluginCheck page is opened on startup, the plugins.update.notifyUser pref is reset, ensuring the page isn't automatically opened again. This should also be reset if the user visits the PluginCheck page via clicking the "Update Plugins..." notificationbar button.

Comment 1

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch v1

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

I'm wondering if it should also be resetting this pref when the PluginCheck page is opened via the "More information" link in the Extension Manager. Unfortunately, that's a bit more complicated.

Comment 3

[Johnathan Nightingale [:johnath]]

Wouldn't block, but would be nice to have - avoids a nuisance, should be very (very!) low risk.

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/86bc6827de21

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 410445 [details] [diff] [review]
Patch v1

a192=beltzner

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/fd94e4f6c80b