526686 - Sprinkle some QueryInterface methods around exposed objects

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Jeff Walden [:Waldo]]

It would have been helpful for sicking, for example, if Response.prototype had one.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Add QI methods, tests for their existence; also nsIHttpRequestMetadata ⇒ nsIHttpRequest

This adds QI methods to all the objects httpd.js exposes.  I also added a little bit of testing to make sure QI methods are present and respond when prodded with the most specific XPCOM interface.  Last, I took a step I've meant to do for a long time and renamed nsIHttpRequestMetadata to nsIHttpRequest, for symmetry with nsIHttpResponse, since I had to add more users of the request interface.  (There's one large hunk rearranging ServerIdentity.prototype, but it contains no substantive changes -- the diff algorithm just isn't recognizing that a small hunk is being moved rather than a large hunk.)

I don't think it's really worth anyone's time to review these changes, the majority of which are straightforward and uncomplicated, so I'll probably land this sometime soon.  There are a couple other changes elsewhere with which this might conflict (I haven't closely examined those patches so I may be wrong), so I don't plan to land this until any overlaps are resolved.

Comment 2

[Jeff Walden [:Waldo]]

Turns out I was wrong, and there shouldn't be any conflicts.  Pushed to m-c:

http://hg.mozilla.org/mozilla-central/rev/e7e60de2a842