526793 - Add gczeal() function to xpcshell

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[[e-mail]]

This would be useful for unit tests, to detect GC hazards. For instance, one could do "gczeal(2);", and expect exercised code to crash if code has obvious liveness/rooting flaws. jsshell has this feature; though this bug may belong in Testing/TUnit rather than xpcshell proper. (do_setgczeal?)

I would certainly use this in unit tests for jsctypes, for instance, which uses JSAPI heavily and has many opportunities for gc hazards.

Comment 1

[Jeff Walden [:Waldo]]

Nope, it's xpcshell proper, probably about ten lines.

Comment 2

[Josh Matthews [:jdm]]

Attachment: Patch

This did not take very long at all, but it's my first time touching js stuff.  Please be gentle?

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 433207 [details] [diff] [review]
Patch

r=me if you use JS_ValueToECMAUint32, as the regular JS shell does.

Comment 4

[Josh Matthews [:jdm]]

Attachment: Patch + comment addressed

Now using ValueToECMABlahblah.

Comment 5

[Josh Matthews [:jdm]]

Attachment: Patch

Now with IRC comments about early return addressed.

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/tracemonkey/rev/fb40471645ea

Comment 7

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/fb40471645ea