avmshell should print out what type of build it is when displaying info

VERIFIED FIXED

Status

Tamarin
Virtual Machine
--
enhancement
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: Chris Peyer, Assigned: Chris Peyer)

Tracking

Details

Attachments

(2 attachments, 3 obsolete attachments)

(Assignee)

Description

8 years ago
The build files always generate the executable avmshell regardless of configuration.  In order to help our test scripts, it would be useful for the avmshell to print out something like this in the info string:

avmplus release-debugger shell 1.4 build 2984:89e6ebc7bad6

The most important configs would be:
release = avmshell
release-debugger = avmshell_s
debug = avmshell_d
debug-debugger = avmshell_sd
Flags: flashplayer-qrb?
(Assignee)

Comment 1

8 years ago
Created attachment 410614 [details] [diff] [review]
Output avm type in info string
Attachment #410614 - Flags: review?(rreitmai)

Comment 2

8 years ago
Created attachment 410625 [details] [diff] [review]
cleanup...untested

Cleanup up the previous ifdef tangle a bit.

Updated

8 years ago
Attachment #410614 - Flags: review?(rreitmai) → review-

Comment 3

8 years ago
Comment on attachment 410614 [details] [diff] [review]
Output avm type in info string

let try to remove the ifdef from the cpp file.

Attached revised patch untested
(Assignee)

Comment 4

8 years ago
Created attachment 410641 [details] [diff] [review]
Change order of wording from last patch

Tested locally - works as expected.
Assignee: nobody → cpeyer
Attachment #410614 - Attachment is obsolete: true
Attachment #410625 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #410641 - Flags: review?(rreitmai)

Updated

8 years ago
Attachment #410641 - Flags: review?(rreitmai) → review+
(Assignee)

Updated

8 years ago
Flags: flashplayer-qrb?
(Assignee)

Comment 5

8 years ago
Created attachment 410654 [details] [diff] [review]
Determine avmshell type in runtestBase based on build type

Brent - Also wanted your feedback on how the string should be ordered.  It is now outputting the shell type between the shell version and build.

e.g:
avmplus shell 1.4 release-debugger build 1234:asldfhjeowi
Attachment #410654 - Flags: review?(brbaker)
(Assignee)

Comment 6

8 years ago
Created attachment 410657 [details] [diff] [review]
patch with actual changes to runtestBase
Attachment #410654 - Attachment is obsolete: true
Attachment #410657 - Flags: review?(brbaker)
Attachment #410654 - Flags: review?(brbaker)

Updated

8 years ago
Attachment #410657 - Flags: review?(brbaker) → review+

Updated

8 years ago
Blocks: 527015
(Assignee)

Comment 7

8 years ago
Pushed to redux 3012:6bbb910d0e53
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Updated

8 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.