Closed
Bug 526883
Opened 16 years ago
Closed 16 years ago
Sampler buffer gets exhausted and the samples are lost if callback is not registered
Categories
(Tamarin Graveyard :: Virtual Machine, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
flash10.1
People
(Reporter: rulohani, Assigned: rulohani)
Details
Attachments
(1 file)
|
1.15 KB,
patch
|
stejohns
:
review+
|
Details | Diff | Splinter Review |
Sampler buffer is currently set to 16 megs. The sample buffer should be large if no callback has been registered. The sample buffer can be smaller when there is a registered callback, since callback is called when the buffer is running low on space.
Attachment #410621 -
Flags: review?(stejohns)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 410621 [details] [diff] [review]
Patch
conceptually fine, but wouldn't it be simpler to write
int megs = (callback != NULL) ? 16 : 256;
Attachment #410621 -
Flags: review?(stejohns) → review+
|
|
||
Updated•16 years ago
|
Priority: -- → P3
|
|
||
Comment 2•16 years ago
|
||
pushed to redux as changeset: 3023:a415cc0cf8f3
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•