526921 - add-ons get installed before user confirmation

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Fabrice Desré]

Attachment: experimental add-on installing before confirmation

Add-ons from AMO sometimes get installed before the user confirms or cancels the install. The alert is displayed showing "Installing addons" and then "Installation complete".

Strangely I've only be able to reproduce this with experimental add-ons (see screenshot).

This is very dangerous since a naive user hitting "cancel" will end up with an installed add-on on the next restart without noticing anything.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

That's a very strange behaviour

Comment 2

[Aakash Desai [:aakashd]]

I see this with recommended (i.e. URL Fixer and GeoGuide) add-ons too when installing from Mobile AMO.

Comment 3

[Aakash Desai [:aakashd]]

Once  bug 528867 is fixed, this should be marked as blocking-fennec?

Comment 4

[Fabrice Desré]

This is caused by an "unload" event that is caught by the dialog. 

The event has the following properties :
event.originalTarget = [object XPCNativeWrapper [object HTMLDocument]]
event.type = unload
event.target = [object XPCNativeWrapper [object HTMLDocument]]
event.currentTarget = [object ChromeWindow]
event.eventPhase = 1
event.bubbles = false
event.cancelable = true
event.timeStamp = 0

It looks like it bubbles from the web page ??
event.explicitOriginalTarget = [object XPCNativeWrapper [object HTMLSpanElement]]

Comment 5

[Fabrice Desré]

Attachment: fix

Ignore the event if it comes from HTMLDocument

Comment 6

[Fabrice Desré]

Attachment: updated patch

Now checks that the event comes only from |document|

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/e2221b8c28a4

Comment 8

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b4pre) Gecko/20091123 Firefox/3.6b4pre Fennec/1.0b6pre

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091123 Firefox/3.7a1pre Fennec/1.0b5


...filed a follow-up bug https://bugzilla.mozilla.org/show_bug.cgi?id=530549 as an edge case was found during verification.