Closed Bug 526952 Opened 11 years ago Closed 11 years ago

Context menu while right-clicking a link should open the link, not link-like text that happens to be selected

Categories

(Firefox :: Menus, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3.7a1

People

(Reporter: philor, Assigned: Natch)

Details

Attachments

(1 file)

It looks like the code to allow treating selected link-like text as a link for context menu things like Open in Tab didn't think about what should be done when you have both selected text, and a right-click on a link.

STR:
1. Open http://tests.themasta.com/tinderboxpushlog/
2. Find a failed test run (that's the easy part) and click on the orange letter to open the summary
3. Select the text of the filename for the first failing test, like test_pluginstream_asfile.html
4. Right click, select "Search Bugzilla@Mozilla.org for test_pluginstream_asfile.html" (with a sane pref to open searches in a new tab)
5. In the tbpl page, without clearing the selection, right click the "View Brief Log" link, and select "Open Link in New Tab"

Expected:
The tinderbox log loads in a new tab.

Actual:
http://www.test_pluginstream_asfile.html/ fails to load in a new tab, since our test filenames tend not to also be domain names.
Should be simple, taking.
Assignee: nobody → highmind63
Attached patch patch & testSplinter Review
Dao, you reviewed the patch for this before. This is a simple patch that bypasses the plain text linking if there's a link in the popup node. Comes with a test!
Attachment #411724 - Flags: review?(dao)
Status: NEW → ASSIGNED
Works perfectly for my use case, anyway :)
Attachment #411724 - Flags: review?(dao) → review+
I haven't been at my computer for a while, gonna have to ask someone to check this in for me :)
Keywords: checkin-needed
Pushed: http://hg.mozilla.org/mozilla-central/rev/b954fa0cf07e
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
You need to log in before you can comment on or make changes to this bug.