526963 - Permanent TM tinderbox orange since October 29 m-c merge

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

Ever since http://hg.mozilla.org/tracemonkey/rev/88cfae411a2a all three platforms' Mochitest boxes have been orange with roughly the same errors (maybe an occasional one shows something slightly different, but it's not at all common):

TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/safebrowsing/content/test/browser_bug400731.js | Timed out
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/safebrowsing/content/test/browser_bug400731.js | Ignore warning button should be present for malware
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgr_sort.js | Timed out
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | Timed out
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/xpinstall/tests/browser_auth.js | Install should succeed - Got -228, expected 0

I also see consistently see these extra failures in Linux/Windows build logs:

TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/safebrowsing/content/test/browser_bug415846.js | Report phishing menu should be hidden on phishing sites - Got false, expected true
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/safebrowsing/content/test/browser_bug415846.js | Report error menu item should be visible on phishing sites - Got true, expected false

Why has no one noticed this permanent orange before now, and why have we been pushing through it for over a week?  (CC list is everyone who pushed anything more than just tests since then.)

Comment 1

[David Mandelin [:dmandelin]]

I suspect it's because the mochitest boxes moved to a new tinderbox page when people weren't looking. Is the unit test page [1] the one we should be looking at to assess tree health now?

[1] http://tinderbox.mozilla.org/showbuilds.cgi?tree=TraceMonkey-Unittest

Comment 2

[Nicholas Nethercote [inactive]]

With the new nanojit repo if you push to nanojit-central and then somebody else propagates the change to tracemonkey it looks like you did the push but really you didn't.  I'm pretty sure I haven't pushed anything to tracemonkey in since Oct 29, and others may be in the same boat.

Comment 3

[Jeff Walden [:Waldo]]

Even without it, if someone else pushes your change it looks like you pushed.  :-)  My mistake on that, I think I somehow globbed your name in when skimming pushlog.

I think that's the right tree to look at; it's where those boxes show up when I look at the TraceMonkey tinderboxpushlog:

http://tests.themasta.com/tinderboxpushlog/?tree=TraceMonkey

Comment 4

[Robert Sayre]

fixed by merges and tings.