526979 - unexpected shared property value between object instance

Status: RESOLVED INVALID

(Core :: JavaScript Engine, defect)

Description

[Franck]

The *vp value of a property getter seems to not be stored on the obj object.

In the following case:
  var oa = new MyClass;
  Print(oa.myProperty); // prints 1
  var ob = new MyClass;
  Print(ob.myProperty); // prints 1, expect 2

myProperty is define like this:
JSBool MyProperty(JSContext *cx, JSObject *obj, jsval id, jsval *vp) {
  if ( *vp != JSVAL_VOID )
    return JS_TRUE;
  *vp = INT_TO_JSVAL(index);
  index++;
  return JS_TRUE;
}

Comment 1

[Franck]

Attachment: testcase

Comment 2

[Franck]

The value is stored on the object's prototype.

Comment 3

[Brendan Eich [:brendan]]

(In reply to comment #2)
> The value is stored on the object's prototype.

That's where you defined the property, and your MyProperty getter did nothing to override in the obj instance. Fix it to JS_SetProperty(cx, obj, id, vp) and you get what you want.

/be