527058 - nsHelperAppDlg.js shouldn't do delayed registration

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Benjamin Smedberg]

Attachment: Don't delay registration of nsHelperAppDlg.js, rev. 1

I think nsHelperAppDlg.js copied and pasted some code from somewhere which implements delayed registration. I can't see any reason for this, and appears to help solve the leaks and crashes of bug 519357 on the branch (which is really weird, but hey, I'm not going to complain to loudly).

Comment 1

[Shawn Wilsher :sdwilsh]

Comment on attachment 410821 [details] [diff] [review]
Don't delay registration of nsHelperAppDlg.js, rev. 1

r=sdwilsh

Comment 2

[Benjamin Smedberg]

http://hg.mozilla.org/mozilla-central/rev/3e10401d7e36
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/2890cab88b77

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Tested that the helper application dialog works as expected when trying to save/open an unknown file type right after Firefox has been started with recent builds on trunk and 1.9.2 for all platforms.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20091111 Minefield/3.7a1pre (.NET CLR 3.5.30729) ID:20091111045251

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2b3pre) Gecko/20091111 Namoroka/3.6b3pre (.NET CLR 3.5.30729) ID:20091111045315

Comment 4

[[e-mail]]

(In reply to comment #0)
> I think nsHelperAppDlg.js copied and pasted some code from somewhere which
> implements delayed registration.
Possibly because the sample JS component does. (The embedding version has the same delayed registration.)