527114 - [FyFx] Two parts of the German text "Spread Firefox aufrufen" are on top of each other

Status: VERIFIED FIXED

(Webtools Graveyard :: Five Years of Firefox, defect)

Description

[Seth Bindernagel]

The two parts of the text "Spread Firefox aufrufen" ("Go to Spread Firefox") on the top right of the German site are on top of each other.

See screen shot.

Comment 1

[Seth Bindernagel]

Attachment: Screenshot of de site

Comment 2

[Staś Małolepszy :stas]

I think this will also cause problems for bn-BD: http://viewvc.svn.mozilla.org/vc/projects/fyfx/trunk/locale/bn-BD/LC_MESSAGES/messages.po?revision=55330&view=markup#l55

Comment 3

[Andres Garcia]

Hi, I checked the "de" po file and noticed that the html is different:
English version:
<span>Go to</span><span class=\"spreadfirefox-text\"> SpreadFirefox</span>

German version:
<span class=\"spreadfirefox-text\">SpreadFirefox </span><span>aufrufen</span>

So I'd need to create specific css rules for this text since "spreadfirefox" is
an image that fits in a certain position of the background.

To do this, I' need to apply css content selectors that are not supported on
all browsers, OR make some js approach.

Do you think we are going to have more languages with this specific rule?

thanks!

Comment 4

[Julen Ruiz Aizpuru]

(In reply to comment #3)
> 
> Do you think we are going to have more languages with this specific rule?

Yes, the same applies to the Basque (eu) site. We have text before and after the "SpreadFirefox" text/image.

Comment 5

[Staś Małolepszy :stas]

Given how little time we have left before Monday, I'd shoot for the simplest solution...

Localizers: are you OK if we don't use text in this link for de, bn-BD and eu at all? I know this is not perfect, but at least the text won't be rendered on top of the image, and the link will still look compelling, IMHO. What do you think?

Andres: Do you think you could prepare a alternative version of the background graphic for a no-text scenario?

Comment 6

[Julen Ruiz Aizpuru]

I'm happy with no text.

Comment 7

[Michael Köhler [:Coce]]

I'm ok with that, too.

Comment 8

[Staś Małolepszy :stas]

Thanks guys. I think [fa] could use the same solution, it has a similar problem (see bug 527152).

Comment 9

[Vlado Valastiak [:wladow]]

Attachment: text partly covered

Stas, what about this? It's "Prejst na SpreadFirefox" with "na" covered by the graphic. This should be easy fixable on the server side, right?

Comment 10

[Andres Garcia]

HI, Stas, just to clarify, do you need just the image background without the the text "SpreadFIREFOX" so the entire text will be placed as HTML without the custom calligraphic text? OR, are you going to place no text there so the link will read just "SpreadFIREFOX" using the Calligraphic image on the background?

thanks!!

Comment 11

[Staś Małolepszy :stas]

(In reply to comment #9)
> Created an attachment (id=410961) [details]
> text partly covered
> 
> Stas, what about this? It's "Prejst na SpreadFirefox" with "na" covered by the
> graphic. This should be easy fixable on the server side, right?

Wladow, not so easy, unfortunately. The background image's width is fixed, and
so is the space for the "go to" translation... Sorry about this.  Right now I
can suugest trying other translation, maybe "visit" or "see"? Or maybe even
"→"?

If that doesn't work, can we leave the text out entirely for Slovak? (see
comment 5)

Comment 12

[Staś Małolepszy :stas]

(In reply to comment #10)
> HI, Stas, just to clarify, do you need just the image background without the
> the text "SpreadFIREFOX" so the entire text will be placed as HTML without the
> custom calligraphic text? OR, are you going to place no text there so the link
> will read just "SpreadFIREFOX" using the Calligraphic image on the background?

Andres: sorry for not being clear about this. I meant using "Spreadfirefox" image only, without the "go to" text. That's option no. 2 from your question.

Julen, Coce: are you OK with this?

Comment 13

[Andres Garcia]

Thank you Stas... in that case, the Localizers just need to remove the "go to" text from the html spam this way:
<span></span><span class=\"spreadfirefox-text\"> SpreadFirefox</span>

Please let me know if it works.

Comment 14

[Michael Köhler [:Coce]]

I'm OK with that, I'm going to check in an updated messages.po to remove the "go to" text.

Comment 15

[Michael Köhler [:Coce]]

I've checked in r55432 and also removed the space behind the word "SpreadFirefox".

Comment 16

[Seth Bindernagel]

Attachment: Fix of the [de] site

I tested Coce's fix on stage.  

http://fyfx.stage.mozilla.com/de/

This screen shot shows the fix.

Comment 17

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED.