Closed Bug 527186 Opened 10 years ago Closed 10 years ago

type ahead in fennec's Select Dialog

Categories

(Firefox for Android Graveyard :: General, defect, major)

defect
Not set
major

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: dougt, Assigned: vingtetun)

References

()

Details

Attachments

(1 file, 1 obsolete file)

There are many irc servers listed on:

http://www.mibbit.com/chat/

Fennec will happily bring up a dialog that allows you to select which server you want.  I assume that these are just the options in a html select.

One of the things that I commonly do is to type the letter of the item i am to avoid scrolling through a long list.  For example, if I wanted to connect to Mozilla's irc server, i would press 'm'.

When doing that in a b5 pre build, the web content correctly updates itself, but fennec's select dialog ignores my keypress.

This inconsistently is a bit confusing to me and I am sure to others.

I think that the fennec's select dialog should list to key presses to allow such a use case.
Taking. I will probably do a cross implementation of this feature + bug 522312
Assignee: nobody → 21
Attached patch Patch (obsolete) — Splinter Review
I'm wondering if we should rename _control._control to _control.element
Attachment #411866 - Flags: review?(mark.finkle)
Attached patch Patch v0.2Splinter Review
Updated patch
Attachment #411866 - Attachment is obsolete: true
Attachment #420352 - Flags: review?(mark.finkle)
Comment on attachment 420352 [details] [diff] [review]
Patch v0.2

>diff -r 0107884be9bd chrome/content/browser-ui.js

>     }
>+    else
>+      scrollBoxObject.scrollTo(0, 0);

nit: use { } around the else
r+ otherwise
Attachment #420352 - Flags: review?(mark.finkle) → review+
Whiteboard: [fennec-checkin-post1.0]
pushed:
http://hg.mozilla.org/mobile-browser/rev/ae3f3642ec42
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fennec-checkin-post1.0]
verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.2pre) Gecko/20100217 Namoroka/3.6.2pre Fennec/1.1a2pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a2pre) Gecko/20100217 Namoroka/3.7a2pre Fennec/1.1a2pre

and

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2.2pre) Gecko/20100217 Namoroka/3.6.2pre Fennec/1.0a4pre


...also a follow-up bug has been filed for softkb interactions with this feature. https://bugzilla.mozilla.org/show_bug.cgi?id=546659
Status: RESOLVED → VERIFIED
Flags: in-litmus?
litmus testcase https://litmus.mozilla.org/show_test.cgi?id=11569 has been created to regression test this bug.
Flags: in-litmus? → in-litmus+
You need to log in before you can comment on or make changes to this bug.