Closed Bug 527235 Opened 10 years ago Closed 10 years ago

^L characters in comm-central source cause parsing errors with DXR

Categories

(MailNews Core :: MIME, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.1a1

People

(Reporter: ehren.m, Assigned: ehren.m)

Details

(Keywords: student-project)

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4) Gecko/20091028 Iceweasel/3.5.4 (Debian-3.5.4-1)
Build Identifier: 

DXR contains a C++ parser to create HTML files with markup versions of source code. A ^L character in each of these files causes the parser to choke:

comm-central/mailnews/mime/src/mimei.h:414:

comm-central/mailnews/mime/src/mimeenc.cpp:852:

A patch removing the characters is attached.

Reproducible: Always
Attachment #410981 - Flags: review+
Component: General → MIME
Product: Thunderbird → MailNews Core
QA Contact: general → mime
Comment on attachment 410981 [details] [diff] [review]
patch to remove ^L characters

You need to _request_ r/sr from a mailnews peer.
Attachment #410981 - Flags: review+
He's learning, not everyone knows the system!  Why not suggest someone for him instead of just pointing out the error, or at least teach him how.
Assignee: nobody → ehren.m
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Keywords: student-project
Attachment #410981 - Flags: review?(ducarroz)
Attachment #410981 - Flags: superreview?(bienvenu)
Attachment #410981 - Flags: review?(ducarroz) → review?(bienvenu)
Comment on attachment 410981 [details] [diff] [review]
patch to remove ^L characters

looks reasonable, thx. I will try to remember to check this in soon.
Attachment #410981 - Flags: superreview?(bienvenu)
Attachment #410981 - Flags: superreview+
Attachment #410981 - Flags: review?(bienvenu)
Attachment #410981 - Flags: review+
fix checked in for 3.1, thx for the patch.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1a1
You need to log in before you can comment on or make changes to this bug.