Are we setting AVMPLUS_UNALIGNED_ACCESS correctly in all cases?

VERIFIED FIXED in flash10.1

Status

P2
normal
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: stejohns, Assigned: stejohns)

Tracking

unspecified
flash10.1
ARM
All
Dependency tree / graph
Bug Flags:
flashplayer-qrb +

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Currently we enable it only for x86 and x64, but anecdotally, newer ARM chips (Cortex A8 and later) allow unaligned access. Flipping this compile flag would generate substantially better code in some cases.
(Assignee)

Updated

9 years ago
Blocks: 458279

Updated

9 years ago
Assignee: nobody → stejohns
Status: NEW → ASSIGNED
Flags: flashplayer-qrb+
Priority: -- → P2
Target Milestone: --- → flash10.1
(Assignee)

Updated

9 years ago
Depends on: 542133
(Assignee)

Comment 1

9 years ago
Created attachment 426362 [details] [diff] [review]
Patch

This removes AVMPLUS_UNALIGNED_ACCESS in favor of AVMSYSTEM_UNALIGNED_ACCESS/VMCFG_UNALIGNED_ACCESS, which is handled much like little-endian detection.

Note that this requires the patch from bug 542133.

Note that AVMPLUS_UNALIGNED_ACCESS was unused outside of the VM proper (gasp!) so it was removed entirely!
Attachment #426362 - Flags: review?(lhansen)

Comment 2

9 years ago
Comment on attachment 426362 [details] [diff] [review]
Patch

Need to correct the syntax in avmfeatures.as:

"... to load and assembly ..." should probably be "... to load and assemble ..."
Attachment #426362 - Flags: review?(lhansen) → review+
(Assignee)

Comment 3

9 years ago
(In reply to comment #2)
> "... to load and assembly ..." should probably be "... to load and assemble
> ..."

Nice catch, will do.
(Assignee)

Comment 4

9 years ago
http://hg.mozilla.org/tamarin-redux/rev/77aaca5caa3f
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Comment 5

9 years ago
Engineering work item.  Marking verified fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.