Closed
Bug 527258
Opened 15 years ago
Closed 15 years ago
Are we setting AVMPLUS_UNALIGNED_ACCESS correctly in all cases?
Categories
(Tamarin Graveyard :: Virtual Machine, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
flash10.1
People
(Reporter: stejohns, Assigned: stejohns)
References
Details
Attachments
(1 file)
|
11.57 KB,
patch
|
lhansen
:
review+
|
Details | Diff | Splinter Review |
Currently we enable it only for x86 and x64, but anecdotally, newer ARM chips (Cortex A8 and later) allow unaligned access. Flipping this compile flag would generate substantially better code in some cases.
Assignee: nobody → stejohns
Status: NEW → ASSIGNED
Flags: flashplayer-qrb+
Priority: -- → P2
Target Milestone: --- → flash10.1
|
Assignee | |
Comment 1•15 years ago
|
||
This removes AVMPLUS_UNALIGNED_ACCESS in favor of AVMSYSTEM_UNALIGNED_ACCESS/VMCFG_UNALIGNED_ACCESS, which is handled much like little-endian detection.
Note that this requires the patch from bug 542133.
Note that AVMPLUS_UNALIGNED_ACCESS was unused outside of the VM proper (gasp!) so it was removed entirely!
Attachment #426362 -
Flags: review?(lhansen)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 426362 [details] [diff] [review]
Patch
Need to correct the syntax in avmfeatures.as:
"... to load and assembly ..." should probably be "... to load and assemble ..."
Attachment #426362 -
Flags: review?(lhansen) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
(In reply to comment #2)
> "... to load and assembly ..." should probably be "... to load and assemble
> ..."
Nice catch, will do.
|
|
Assignee | |
Comment 4•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•