Typo in SettingsStore() makes settings basically unusable

RESOLVED FIXED in 0.7

Status

P1
normal
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: adw, Assigned: adw)

Tracking

unspecified

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 411021 [details] [diff] [review]
patch

http://hg.mozilla.org/labs/jetpack/rev/bea8531381a0 added a typeof() check in SettingsStore(), except it's written as type().  No such function is defined, and it looks like this basically makes settings unusable, although I haven't manually tested.  The settings test fails, though, and that's how I noticed this.

I'm going to go ahead and push this patch.  I think we should release a 0.6.1 ASAP.
(Assignee)

Comment 1

9 years ago
http://hg.mozilla.org/labs/jetpack/rev/2b8dc2b4178d
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.